content/shell/test_runner/web_frame_test_client.cc - Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/web_frame_test_client.cc

Issue 2831583004: Remove redundant WebLocalFrame* parameter from DidClearWindowObject (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/web_frame_test_client.cc

diff --git a/content/shell/test_runner/web_frame_test_client.cc b/content/shell/test_runner/web_frame_test_client.cc

index ef6fa936307a78e9828c288e27b9650f885e249a..9a524f5e74479190d9253b58b80de7d8af59161b 100644

--- a/content/shell/test_runner/web_frame_test_client.cc

+++ b/content/shell/test_runner/web_frame_test_client.cc

@@ -722,8 +722,8 @@ void WebFrameTestClient::CheckIfAudioSinkExistsAndIsAuthorized(

callback->OnError(blink::WebSetSinkIdError::kNotFound);

}

-void WebFrameTestClient::DidClearWindowObject(blink::WebLocalFrame* frame) {

- DCHECK_EQ(frame, web_frame_test_proxy_base_->web_frame());

+void WebFrameTestClient::DidClearWindowObject() {

+ blink::WebLocalFrame* frame = web_frame_test_proxy_base_->web_frame();

web_view_test_proxy_base_->test_interfaces()->BindTo(frame);

web_view_test_proxy_base_->BindTo(frame);

delegate_->GetWebWidgetTestProxyBase(frame)->BindTo(frame);