Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2824773002: Rename ScopedComPtr::get() to ScopedComPtr::Get() (Closed)

Created:
3 years, 8 months ago by robliao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, dcheng, pennymac+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, toyoshim+midi_chromium.org, aboxhall+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, net-reviews_chromium.org, je_julie, darin-cc_chromium.org, wanming.lin, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, mlamouri+watch-content_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, timvolodine, asvitkine+watch_chromium.org, mlamouri+watch-sensors_chromium.org, piman+watch_chromium.org, shalamov, riju_, Lei Zhang, tfarina, nektar+watch_chromium.org, tommycli, dtseng+watch_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ScopedComPtr::get() to ScopedComPtr::Get() This renames get() to Get() to harmonize with ComPtr::Get(). Most replacements were performed automatically with clang-tidy. BUG=638327 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=dalecurtis@chromium.org, jam@chromium.org, kbr@chromium.org, reillyg@chromium.org, rsleevi@chromium.org, sdefresne@chromium.org, thestig@chromium.org, thakis@chromium.org, wez@chromium.org, Mechanical rename. Review-Url: https://codereview.chromium.org/2824773002 Cr-Commit-Position: refs/heads/master@{#465432} Committed: https://chromium.googlesource.com/chromium/src/+/b44b907bbf8615ec03c9f97591fec845747c627e

Patch Set 1 #

Patch Set 2 : Update to 5293966 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, -540 lines) Patch
M base/test/test_shortcut_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/scoped_comptr.h View 6 chunks +8 lines, -8 lines 0 comments Download
M base/win/scoped_comptr_unittest.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M base/win/shortcut.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/google/google_update_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/media_galleries/win/portable_device_map_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/snapshot_file_details.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/antivirus_metrics_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/tts_win.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/win/jumplist_updater.cc View 1 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/win/settings_app_monitor.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/installer/util/advanced_firewall_manager_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/legacy_firewall_manager_win.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/wmi.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M components/update_client/background_downloader_win.cc View 13 chunks +17 lines, -17 lines 0 comments Download
M content/browser/accessibility/accessibility_event_recorder_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 12 chunks +31 lines, -31 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_and_provider_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/platform_sensor_reader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/sensors/data_fetcher_shared_memory_win.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M gpu/ipc/service/direct_composition_surface_win.cc View 20 chunks +31 lines, -31 lines 0 comments Download
M media/audio/win/audio_device_listener_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 16 chunks +26 lines, -26 lines 0 comments Download
M media/audio/win/core_audio_util_win_unittest.cc View 21 chunks +59 lines, -59 lines 0 comments Download
M media/base/win/mf_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/filter_base_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/win/pin_base_win.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M media/capture/video/win/video_capture_device_mf_win.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 11 chunks +25 lines, -25 lines 0 comments Download
M media/gpu/d3d11_h264_accelerator.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M media/gpu/d3d11_video_decode_accelerator_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/dxva_picture_buffer_win.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 37 chunks +52 lines, -52 lines 0 comments Download
M media/gpu/media_foundation_video_encode_accelerator_win.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M media/midi/midi_manager_winrt.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/url_security_manager_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M printing/backend/print_backend_win.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M printing/backend/win_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/audio_capturer_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/host/desktop_session_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/win/auth_code_getter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_client_window.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_win.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_win_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/base/win/shell.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/font_fallback_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/platform_font_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/win/direct_manipulation.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/win/direct_write.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_angle_util_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (21 generated)
robliao
scottmg: Please review this CL. Thanks!
3 years, 8 months ago (2017-04-17 18:01:08 UTC) #6
scottmg
It's unfortunate that this is a divergence from more standard-C++-lie get() on smart pointers, but ...
3 years, 8 months ago (2017-04-18 17:25:59 UTC) #9
scottmg
On 2017/04/18 17:25:59, scottmg wrote: > It's unfortunate that this is a divergence from more ...
3 years, 8 months ago (2017-04-18 17:26:17 UTC) #10
robliao
TBR'ing top-level directory owners for this mechanical rename. Owners: dalecurtis: media/* jam: content/* kbr: gpu/* ...
3 years, 8 months ago (2017-04-18 19:47:39 UTC) #13
Reilly Grant (use Gerrit)
device/* lgtm
3 years, 8 months ago (2017-04-18 19:58:23 UTC) #18
Sergey Ulanov
remoting lgtm
3 years, 8 months ago (2017-04-18 20:00:58 UTC) #20
Ryan Sleevi
net/ LGTM
3 years, 8 months ago (2017-04-18 20:20:05 UTC) #21
Lei Zhang
base, chrome, and printing lgtm
3 years, 8 months ago (2017-04-18 20:39:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824773002/20001
3 years, 8 months ago (2017-04-18 22:25:13 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/b44b907bbf8615ec03c9f97591fec845747c627e
3 years, 8 months ago (2017-04-19 00:29:24 UTC) #31
sdefresne
3 years, 8 months ago (2017-04-19 08:52:55 UTC) #32
Message was sent while issue was closed.
components/ lgtm

Powered by Google App Engine
This is Rietveld 408576698