Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: base/win/scoped_comptr_unittest.cc

Issue 2824773002: Rename ScopedComPtr::get() to ScopedComPtr::Get() (Closed)
Patch Set: Update to 5293966 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/win/scoped_comptr.h ('k') | base/win/shortcut.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/scoped_comptr.h" 5 #include "base/win/scoped_comptr.h"
6 6
7 #include <objbase.h> 7 #include <objbase.h>
8 #include <shlobj.h> 8 #include <shlobj.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 24 matching lines...) Expand all
35 } // namespace 35 } // namespace
36 36
37 TEST(ScopedComPtrTest, ScopedComPtr) { 37 TEST(ScopedComPtrTest, ScopedComPtr) {
38 base::win::ScopedCOMInitializer com_initializer; 38 base::win::ScopedCOMInitializer com_initializer;
39 EXPECT_TRUE(com_initializer.succeeded()); 39 EXPECT_TRUE(com_initializer.succeeded());
40 40
41 ScopedComPtr<IUnknown> unk; 41 ScopedComPtr<IUnknown> unk;
42 EXPECT_TRUE(SUCCEEDED(unk.CreateInstance(CLSID_ShellLink))); 42 EXPECT_TRUE(SUCCEEDED(unk.CreateInstance(CLSID_ShellLink)));
43 ScopedComPtr<IUnknown> unk2; 43 ScopedComPtr<IUnknown> unk2;
44 unk2.Attach(unk.Detach()); 44 unk2.Attach(unk.Detach());
45 EXPECT_TRUE(unk.get() == NULL); 45 EXPECT_TRUE(unk.Get() == NULL);
46 EXPECT_TRUE(unk2.get() != NULL); 46 EXPECT_TRUE(unk2.Get() != NULL);
47 47
48 ScopedComPtr<IMalloc> mem_alloc; 48 ScopedComPtr<IMalloc> mem_alloc;
49 EXPECT_TRUE(SUCCEEDED(CoGetMalloc(1, mem_alloc.Receive()))); 49 EXPECT_TRUE(SUCCEEDED(CoGetMalloc(1, mem_alloc.Receive())));
50 50
51 ScopedComPtr<IUnknown> qi_test; 51 ScopedComPtr<IUnknown> qi_test;
52 EXPECT_HRESULT_SUCCEEDED(mem_alloc.QueryInterface(IID_PPV_ARGS(&qi_test))); 52 EXPECT_HRESULT_SUCCEEDED(mem_alloc.QueryInterface(IID_PPV_ARGS(&qi_test)));
53 EXPECT_TRUE(qi_test.get() != NULL); 53 EXPECT_TRUE(qi_test.Get() != NULL);
54 qi_test.Reset(); 54 qi_test.Reset();
55 55
56 // test ScopedComPtr& constructor 56 // test ScopedComPtr& constructor
57 ScopedComPtr<IMalloc> copy1(mem_alloc); 57 ScopedComPtr<IMalloc> copy1(mem_alloc);
58 EXPECT_TRUE(copy1.IsSameObject(mem_alloc.get())); 58 EXPECT_TRUE(copy1.IsSameObject(mem_alloc.Get()));
59 EXPECT_FALSE(copy1.IsSameObject(unk2.get())); // unk2 is valid but different 59 EXPECT_FALSE(copy1.IsSameObject(unk2.Get())); // unk2 is valid but different
60 EXPECT_FALSE(copy1.IsSameObject(unk.get())); // unk is NULL 60 EXPECT_FALSE(copy1.IsSameObject(unk.Get())); // unk is NULL
61 61
62 IMalloc* naked_copy = copy1.Detach(); 62 IMalloc* naked_copy = copy1.Detach();
63 copy1 = naked_copy; // Test the =(T*) operator. 63 copy1 = naked_copy; // Test the =(T*) operator.
64 naked_copy->Release(); 64 naked_copy->Release();
65 65
66 copy1.Reset(); 66 copy1.Reset();
67 EXPECT_FALSE(copy1.IsSameObject(unk2.get())); // unk2 is valid, copy1 is not 67 EXPECT_FALSE(copy1.IsSameObject(unk2.Get())); // unk2 is valid, copy1 is not
68 68
69 // test Interface* constructor 69 // test Interface* constructor
70 ScopedComPtr<IMalloc> copy2(static_cast<IMalloc*>(mem_alloc.get())); 70 ScopedComPtr<IMalloc> copy2(static_cast<IMalloc*>(mem_alloc.Get()));
71 EXPECT_TRUE(copy2.IsSameObject(mem_alloc.get())); 71 EXPECT_TRUE(copy2.IsSameObject(mem_alloc.Get()));
72 72
73 EXPECT_TRUE(SUCCEEDED(unk.QueryFrom(mem_alloc.get()))); 73 EXPECT_TRUE(SUCCEEDED(unk.QueryFrom(mem_alloc.Get())));
74 EXPECT_TRUE(unk.get() != NULL); 74 EXPECT_TRUE(unk.Get() != NULL);
75 unk.Reset(); 75 unk.Reset();
76 EXPECT_TRUE(unk.get() == NULL); 76 EXPECT_TRUE(unk.Get() == NULL);
77 EXPECT_TRUE(unk.IsSameObject(copy1.get())); // both are NULL 77 EXPECT_TRUE(unk.IsSameObject(copy1.Get())); // both are NULL
78 } 78 }
79 79
80 TEST(ScopedComPtrTest, ScopedComPtrVector) { 80 TEST(ScopedComPtrTest, ScopedComPtrVector) {
81 // Verify we don't get error C2558. 81 // Verify we don't get error C2558.
82 typedef ScopedComPtr<Dummy, &dummy_iid> Ptr; 82 typedef ScopedComPtr<Dummy, &dummy_iid> Ptr;
83 std::vector<Ptr> bleh; 83 std::vector<Ptr> bleh;
84 84
85 std::unique_ptr<Dummy> p(new Dummy); 85 std::unique_ptr<Dummy> p(new Dummy);
86 { 86 {
87 Ptr p2(p.get()); 87 Ptr p2(p.get());
88 EXPECT_EQ(p->adds, 1); 88 EXPECT_EQ(p->adds, 1);
89 EXPECT_EQ(p->releases, 0); 89 EXPECT_EQ(p->releases, 0);
90 Ptr p3 = p2; 90 Ptr p3 = p2;
91 EXPECT_EQ(p->adds, 2); 91 EXPECT_EQ(p->adds, 2);
92 EXPECT_EQ(p->releases, 0); 92 EXPECT_EQ(p->releases, 0);
93 p3 = p2; 93 p3 = p2;
94 EXPECT_EQ(p->adds, 3); 94 EXPECT_EQ(p->adds, 3);
95 EXPECT_EQ(p->releases, 1); 95 EXPECT_EQ(p->releases, 1);
96 // To avoid hitting a reallocation. 96 // To avoid hitting a reallocation.
97 bleh.reserve(1); 97 bleh.reserve(1);
98 bleh.push_back(p2); 98 bleh.push_back(p2);
99 EXPECT_EQ(p->adds, 4); 99 EXPECT_EQ(p->adds, 4);
100 EXPECT_EQ(p->releases, 1); 100 EXPECT_EQ(p->releases, 1);
101 EXPECT_EQ(bleh[0].get(), p.get()); 101 EXPECT_EQ(bleh[0].Get(), p.get());
102 bleh.pop_back(); 102 bleh.pop_back();
103 EXPECT_EQ(p->adds, 4); 103 EXPECT_EQ(p->adds, 4);
104 EXPECT_EQ(p->releases, 2); 104 EXPECT_EQ(p->releases, 2);
105 } 105 }
106 EXPECT_EQ(p->adds, 4); 106 EXPECT_EQ(p->adds, 4);
107 EXPECT_EQ(p->releases, 4); 107 EXPECT_EQ(p->releases, 4);
108 } 108 }
109 109
110 } // namespace win 110 } // namespace win
111 } // namespace base 111 } // namespace base
OLDNEW
« no previous file with comments | « base/win/scoped_comptr.h ('k') | base/win/shortcut.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698