Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2823843006: Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++) (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, ntp-dev+reviews_chromium.org, pedrosimonetti+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++) R=dschuyler@chromium.org BUG=677338 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2823843006 Cr-Commit-Position: refs/heads/master@{#465315} Committed: https://chromium.googlesource.com/chromium/src/+/4945caaf823ee78599bf3936bc31963373edc36e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M chrome/browser/resources/ntp4/guest_tab.html View 1 chunk +5 lines, -8 lines 2 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Dan Beam
3 years, 8 months ago (2017-04-18 03:21:39 UTC) #3
dschuyler
lgtm https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/ntp4/guest_tab.html File chrome/browser/resources/ntp4/guest_tab.html (right): https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/ntp4/guest_tab.html#newcode13 chrome/browser/resources/ntp4/guest_tab.html:13: <a class="learn-more-button" href="$i18n{learnMoreLink}">$i18n{learnMore}</a> Just a reminder, (I know ...
3 years, 8 months ago (2017-04-18 18:28:58 UTC) #9
Dan Beam
https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/ntp4/guest_tab.html File chrome/browser/resources/ntp4/guest_tab.html (right): https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/ntp4/guest_tab.html#newcode13 chrome/browser/resources/ntp4/guest_tab.html:13: <a class="learn-more-button" href="$i18n{learnMoreLink}">$i18n{learnMore}</a> On 2017/04/18 18:28:58, dschuyler wrote: > ...
3 years, 8 months ago (2017-04-18 18:59:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823843006/1
3 years, 8 months ago (2017-04-18 19:00:24 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 19:07:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4945caaf823ee78599bf3936bc31...

Powered by Google App Engine
This is Rietveld 408576698