Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823843006
Cr-Commit-Position: refs/heads/master@{#465315}
Committed: https://chromium.googlesource.com/chromium/src/+/4945caaf823ee78599bf3936bc31963373edc36e

[Dan Beam, 2017-04-18 03:19:39]

Description was changed from

==========
Convert the Guest New Tab page to use $i18n{}

R=dschuyler@chromium.org
BUG=677338
==========

to

==========
Convert the Guest New Tab page to use $i18n{}

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-18 03:21:32]

Description was changed from

==========
Convert the Guest New Tab page to use $i18n{}

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Convert the Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-18 03:21:45]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 03:22:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 05:00:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 05:00:16]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-04-18 05:18:38]

Description was changed from

==========
Convert the Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2017-04-18 18:28:58]

lgtm

https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/guest_tab.html (right):

https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/guest_tab.html:13: <a class="learn-more-button"
href="$i18n{learnMoreLink}">$i18n{learnMore}</a>
Just a reminder, (I know ya know, but) if this href has more than one query
param it will need to be i18nRaw. If it's a simple url, it's good as is.

I *think* it may be here, which looks fine:
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/ntp/ntp_resource...

[Dan Beam, 2017-04-18 18:59:23]

https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/nt...
File chrome/browser/resources/ntp4/guest_tab.html (right):

https://codereview.chromium.org/2823843006/diff/1/chrome/browser/resources/nt...
chrome/browser/resources/ntp4/guest_tab.html:13: <a class="learn-more-button"
href="$i18n{learnMoreLink}">$i18n{learnMore}</a>
On 2017/04/18 18:28:58, dschuyler wrote:
> Just a reminder, (I know ya know, but) if this href has more than one query
> param it will need to be i18nRaw. If it's a simple url, it's good as is.
> 
> I *think* it may be here, which looks fine:
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/ntp/ntp_resource...

yep, dodged that bullet this time

[Dan Beam, 2017-04-18 18:59:31]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:00:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:06:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492541971032930, "parent_rev":
"32c7f299bac9dfc90dcdbc2a9273892f01ce18e6", "commit_rev":
"4945caaf823ee78599bf3936bc31963373edc36e"}

[commit-bot: I haz the power, 2017-04-18 19:07:51]

Description was changed from

==========
Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823843006
Cr-Commit-Position: refs/heads/master@{#465315}
Committed:
https://chromium.googlesource.com/chromium/src/+/4945caaf823ee78599bf3936bc31...
==========

[commit-bot: I haz the power, 2017-04-18 19:07:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4945caaf823ee78599bf3936bc31...