Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7735)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 2823843006: Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++) (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index a6ab0c53f09f1ab867d7696471e0fc3676606c53..393ef9d3125bf6149d2d70fafc3ea8e09dde107a 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -369,8 +369,17 @@ void NTPResourceCache::CreateNewTabGuestHTML() {
static const base::StringPiece guest_tab_html(
ResourceBundle::GetSharedInstance().GetRawDataResource(guest_tab_ids));
+#if defined(OS_CHROMEOS)
+ // TODO(dbeam): convert c/b/resources/chromeos/guest_session_tab.html from
+ // i18n-* to $i18n{}.
std::string full_html = webui::GetI18nTemplateHtml(
guest_tab_html, &localized_strings);
+#else
+ ui::TemplateReplacements replacements;
+ ui::TemplateReplacementsFromDictionaryValue(localized_strings, &replacements);
+ std::string full_html =
+ ui::ReplaceTemplateExpressions(guest_tab_html, replacements);
+#endif
new_tab_guest_html_ = base::RefCountedString::TakeString(&full_html);
}
« chrome/browser/resources/ntp4/guest_tab.html ('K') | « chrome/browser/resources/ntp4/guest_tab.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698