chrome/browser/resources/ntp4/guest_tab.html - Issue 2823843006: Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/ntp4/guest_tab.html

Issue 2823843006: Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++) (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html dir="$i18n{textdirection}" lang="$i18n{language}">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="title"></title>	5 <title>$i18n{title}</title>

6 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	6 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

7 <link rel="stylesheet" href="incognito_and_guest_tab.css">	7 <link rel="stylesheet" href="incognito_and_guest_tab.css">

8 </head>	8 </head>

9 <body>	9 <body>

10 <div class="content">	10 <div class="content">

11 <h1 i18n-content="guestTabHeading"></h1>	11 <h1>$i18n{guestTabHeading}</h1>

12 <p>	12 <p>$i18n{guestTabDescription}</p>

13 <span i18n-content="guestTabDescription"></span>	13 <a class="learn-more-button" href="$i18n{learnMoreLink}">$i18n{learnMore}</a>
	dschuyler 2017/04/18 18:28:58 Just a reminder, (I know ya know, but) if this hre Just a reminder, (I know ya know, but) if this href has more than one query param it will need to be i18nRaw. If it's a simple url, it's good as is. I think it may be here, which looks fine: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/ntp/ntp_resource... Dan Beam 2017/04/18 18:59:23 yep, dodged that bullet this time Show quoted text On 2017/04/18 18:28:58, dschuyler wrote: > Just a reminder, (I know ya know, but) if this href has more than one query > param it will need to be i18nRaw. If it's a simple url, it's good as is. > > I think it may be here, which looks fine: > https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/ntp/ntp_resource... yep, dodged that bullet this time
14 </p>

15 <a class="learn-more-button" i18n-content="learnMore" i18n-values=".href:learn MoreLink"></a>

16 </div>	14 </div>

17 </body>	15 </body>

18 <script src="chrome://resources/js/cr.js"></script>

19 </html>	16 </html>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/webui/ntp/ntp_resource_cache.cc » ('j') | no next file with comments »