Chromium Code Reviews Chromium Code Reviews
Issue 2823843006:
Convert Guest New Tab page from i18n-* (JS) to use $i18n{} (C++) (Closed)
| Index: chrome/browser/resources/ntp4/guest_tab.html |
| diff --git a/chrome/browser/resources/ntp4/guest_tab.html b/chrome/browser/resources/ntp4/guest_tab.html |
| index 15b74f042cbe17618ba04aaa5b2fa553a2735426..a89226c66f41d54f4384aaae1cb805b9dc0ba420 100644 |
| --- a/chrome/browser/resources/ntp4/guest_tab.html |
| +++ b/chrome/browser/resources/ntp4/guest_tab.html |
| @@ -1,19 +1,16 @@ |
| <!doctype html> |
| -<html i18n-values="dir:textdirection;lang:language"> |
| +<html dir="$i18n{textdirection}" lang="$i18n{language}"> |
| <head> |
| <meta charset="utf-8"> |
| -<title i18n-content="title"></title> |
| +<title>$i18n{title}</title> |
| <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css"> |
| <link rel="stylesheet" href="incognito_and_guest_tab.css"> |
| </head> |
| <body> |
| <div class="content"> |
| - <h1 i18n-content="guestTabHeading"></h1> |
| - <p> |
| - <span i18n-content="guestTabDescription"></span> |
| - </p> |
| - <a class="learn-more-button" i18n-content="learnMore" i18n-values=".href:learnMoreLink"></a> |
| + <h1>$i18n{guestTabHeading}</h1> |
| + <p>$i18n{guestTabDescription}</p> |
| + <a class="learn-more-button" href="$i18n{learnMoreLink}">$i18n{learnMore}</a> |
|
dschuyler
2017/04/18 18:28:58
Just a reminder, (I know ya know, but) if this hre
Dan Beam
2017/04/18 18:59:23
yep, dodged that bullet this time
|
| </div> |
| </body> |
| -<script src="chrome://resources/js/cr.js"></script> |
| </html> |
