Chromium Code Reviews
DescriptionRevert of Fix the settings button and UMA metrics for the message center (patchset #1 id:1 of https://codereview.chromium.org/2818063002/ )
Reason for revert:
Breaks compile on 'win Beta' for official.desktop.continuous, see https://crbug.com/711712
Original issue's description:
> Fix the settings button and UMA metrics for the message center
>
> The settings button was unintentionally broken for Windows and
> Linux users in 2799653004, as was gathering of some UMA. This
> CL offers a slight refactoring that meets all goals.
>
> BUG=706658
>
> Review-Url: https://codereview.chromium.org/2807623002
> Cr-Commit-Position: refs/heads/master@{#463339}
> (cherry picked from commit 9b6e3c78898f12a0183edffb62d189cb716c6135)
>
> Review-Url: https://codereview.chromium.org/2818063002 .
> Cr-Commit-Position: refs/branch-heads/3029@{#707}
> Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed: https://chromium.googlesource.com/chromium/src/+/ebce3bd778c9770581cb11f2c90219fac48728f4
TBR=yhanada@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706658
Review-Url: https://codereview.chromium.org/2823673002
Cr-Commit-Position: refs/branch-heads/3029@{#718}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/7cf6a4e07de9deee6657a54423cf3e2e1aca9338
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|