Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2823673002: Revert of Fix the settings button and UMA metrics for the message center (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
yhanada
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert of Fix the settings button and UMA metrics for the message center (patchset #1 id:1 of https://codereview.chromium.org/2818063002/ ) Reason for revert: Breaks compile on 'win Beta' for official.desktop.continuous, see https://crbug.com/711712 Original issue's description: > Fix the settings button and UMA metrics for the message center > > The settings button was unintentionally broken for Windows and > Linux users in 2799653004, as was gathering of some UMA. This > CL offers a slight refactoring that meets all goals. > > BUG=706658 > > Review-Url: https://codereview.chromium.org/2807623002 > Cr-Commit-Position: refs/heads/master@{#463339} > (cherry picked from commit 9b6e3c78898f12a0183edffb62d189cb716c6135) > > Review-Url: https://codereview.chromium.org/2818063002 . > Cr-Commit-Position: refs/branch-heads/3029@{#707} > Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} > Committed: https://chromium.googlesource.com/chromium/src/+/ebce3bd778c9770581cb11f2c90219fac48728f4 TBR=yhanada@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706658 Review-Url: https://codereview.chromium.org/2823673002 Cr-Commit-Position: refs/branch-heads/3029@{#718} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7cf6a4e07de9deee6657a54423cf3e2e1aca9338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -31 lines) Patch
M chrome/browser/notifications/message_center_stats_collector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_stats_collector.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/notifications/web_notification_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/web_notification_delegate.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/message_center/message_center_observer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/message_center/message_center_tray.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/message_center_tray.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/message_center/notification_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/message_center/notification_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
alexmos
Created Revert of Fix the settings button and UMA metrics for the message center
3 years, 8 months ago (2017-04-14 20:52:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823673002/1
3 years, 8 months ago (2017-04-14 20:52:25 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 20:56:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7cf6a4e07de9deee6657a54423cf...

Powered by Google App Engine
This is Rietveld 408576698