chrome/browser/notifications/message_center_stats_collector.cc - Issue 2823673002: Revert of Fix the settings button and UMA metrics for the message center

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_stats_collector.cc

Issue 2823673002: Revert of Fix the settings button and UMA metrics for the message center (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/message_center_stats_collector.cc

diff --git a/chrome/browser/notifications/message_center_stats_collector.cc b/chrome/browser/notifications/message_center_stats_collector.cc

index 0c45baf7db49104660165194f7ac2a1bf69ac7bf..459f2de0aed10f93bbd3e262544dd42e35a47e60 100644

--- a/chrome/browser/notifications/message_center_stats_collector.cc

+++ b/chrome/browser/notifications/message_center_stats_collector.cc

@@ -109,8 +109,9 @@

notification_stat.CollectAction(NOTIFICATION_ACTION_BUTTON_CLICK);

}

-void MessageCenterStatsCollector::OnNotificationSettingsClicked(bool handled) {

- base::RecordAction(base::UserMetricsAction("Notifications.ShowSiteSettings"));

+void MessageCenterStatsCollector::OnNotificationSettingsClicked() {

+ content::RecordAction(

+ base::UserMetricsAction("Notifications.ShowSiteSettings"));

}

void MessageCenterStatsCollector::OnNotificationDisplayed(