Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2818063002: Fix the settings button and UMA metrics for the message center (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix the settings button and UMA metrics for the message center The settings button was unintentionally broken for Windows and Linux users in 2799653004, as was gathering of some UMA. This CL offers a slight refactoring that meets all goals. BUG=706658 Review-Url: https://codereview.chromium.org/2807623002 Cr-Commit-Position: refs/heads/master@{#463339} (cherry picked from commit 9b6e3c78898f12a0183edffb62d189cb716c6135) Review-Url: https://codereview.chromium.org/2818063002 . Cr-Commit-Position: refs/branch-heads/3029@{#707} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/ebce3bd778c9770581cb11f2c90219fac48728f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M chrome/browser/notifications/message_center_stats_collector.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_stats_collector.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/notifications/web_notification_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/web_notification_delegate.cc View 1 chunk +6 lines, -1 line 0 comments Download
M ui/message_center/message_center_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/message_center/message_center_observer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/message_center/message_center_tray.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/message_center_tray.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/message_center/notification_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/message_center/notification_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
yhanada
Committed patchset #1 (id:1) manually as ebce3bd778c9770581cb11f2c90219fac48728f4.
3 years, 8 months ago (2017-04-14 04:33:27 UTC) #2
alexmos
3 years, 8 months ago (2017-04-14 20:52:07 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2823673002/ by alexmos@chromium.org.

The reason for reverting is: Breaks compile on 'win Beta' for
official.desktop.continuous, see https://crbug.com/711712.

Powered by Google App Engine
This is Rietveld 408576698