Revert of Stop passing raw pointers to base::Value API in c/b/ui

Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5 id:80001 of https://codereview.chromium.org/2812953002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhYWM0NzFjYzczOTQyNDliMWEzZDMyYTc3N2QwNTM5YzJhZTU0ZDUM

Original issue's description:
> Stop passing raw pointers to base::Value API in c/b/ui
> 
> Passing ownership of base::Value into API methods DictionaryValue::Set,
> DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> pointers is deprecated, can hide bugs and should be done via unique_ptr
> instead.
> 
> Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> 
> BUG=581865
> TBR=dbeam@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2812953002
> Cr-Commit-Position: refs/heads/master@{#464860}
> Committed: https://chromium.googlesource.com/chromium/src/+/4aac471cc7394249b1a3d32a777d0539c2ae54d5

TBR=derat@chromium.org,estade@chromium.org,jdoerrie@chromium.org,msw@chromium.org,dpapad@chromium.org,dbeam@chromium.org,vabr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865
Review-Url: https://codereview.chromium.org/2820823005
Cr-Commit-Position: refs/heads/master@{#464867}
Committed: https://chromium.googlesource.com/chromium/src/+/9a351077393017cd8e0286942e2539144207e10f

[findit-for-me, 2017-04-15 10:07:46]

Created Revert of Stop passing raw pointers to base::Value API in c/b/ui

[findit-for-me, 2017-04-15 10:07:48]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ alexmos@google.com, loyso@google.com, mastiz@google.com, paulmeyer@google.com,
pfeldman@google.com

[findit-for-me, 2017-04-15 10:07:49]

Sheriffs:

Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
If it is a false positive, please close it.

Findit(https://goo.gl/kROfz5) identified the original CL as the culprit
for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[vabr (Chromium), 2017-04-15 10:18:15]

On 2017/04/15 10:07:49, findit-for-me wrote:
> Sheriffs:
> 
> Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> If it is a false positive, please close it.
> 
> Findit(https://goo.gl/kROfz5) identified the original CL as the culprit
> for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

I am looking.
Vaclav

[vabr (Chromium), 2017-04-15 10:19:17]

On 2017/04/15 10:18:15, vabr (Chromium) wrote:
> On 2017/04/15 10:07:49, findit-for-me wrote:
> > Sheriffs:
> > 
> > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > If it is a false positive, please close it.
> > 
> > Findit(https://goo.gl/kROfz5) identified the original CL as the culprit
> > for failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> I am looking.
> Vaclav

Indeed, looks related, LGTM to the revert.

[vabr (Chromium), 2017-04-15 10:19:27]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-04-15 10:19:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 10:21:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492251567795830, "parent_rev":
"7cc8da77161b4ab86ff43a06bda52a53f59a0bff", "commit_rev":
"9a351077393017cd8e0286942e2539144207e10f"}

[commit-bot: I haz the power, 2017-04-15 10:22:11]

Description was changed from

==========
Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Stop passing raw pointers to base::Value API in c/b/ui
> 
> Passing ownership of base::Value into API methods DictionaryValue::Set,
> DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> pointers is deprecated, can hide bugs and should be done via unique_ptr
> instead.
> 
> Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> 
> BUG=581865
> TBR=dbeam@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2812953002
> Cr-Commit-Position: refs/heads/master@{#464860}
> Committed:
https://chromium.googlesource.com/chromium/src/+/4aac471cc7394249b1a3d32a777d...

TBR=derat@chromium.org,estade@chromium.org,jdoerrie@chromium.org,msw@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865
==========

to

==========
Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Stop passing raw pointers to base::Value API in c/b/ui
> 
> Passing ownership of base::Value into API methods DictionaryValue::Set,
> DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> pointers is deprecated, can hide bugs and should be done via unique_ptr
> instead.
> 
> Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> 
> BUG=581865
> TBR=dbeam@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2812953002
> Cr-Commit-Position: refs/heads/master@{#464860}
> Committed:
https://chromium.googlesource.com/chromium/src/+/4aac471cc7394249b1a3d32a777d...

TBR=derat@chromium.org,estade@chromium.org,jdoerrie@chromium.org,msw@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865

Review-Url: https://codereview.chromium.org/2820823005
Cr-Commit-Position: refs/heads/master@{#464867}
Committed:
https://chromium.googlesource.com/chromium/src/+/9a351077393017cd8e0286942e25...
==========

[commit-bot: I haz the power, 2017-04-15 10:22:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9a351077393017cd8e0286942e25...

[vabr (Chromium), 2017-04-15 10:25:31]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2814363006/ by vabr@chromium.org.

The reason for reverting is: Creating a reland CL, will add the fix before
landing..