Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3227)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2820823005: Revert of Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/chrome_launcher_prefs.cc ('k') | chrome/browser/ui/browser_window_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
index 1c3b07e0dd82ade763636f80edc7f87d10d8634f..8b0ef3b949f929f1697efa2a6d47bd0a643be837 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
@@ -327,12 +327,11 @@
"for testing pinned platform apps");
manifest_platform_app.SetString(extensions::manifest_keys::kApp, "true");
manifest_platform_app.Set(extensions::manifest_keys::kPlatformAppBackground,
- base::MakeUnique<base::DictionaryValue>());
- auto scripts = base::MakeUnique<base::ListValue>();
+ new base::DictionaryValue());
+ base::ListValue* scripts = new base::ListValue();
scripts->AppendString("main.js");
manifest_platform_app.Set(
- extensions::manifest_keys::kPlatformAppBackgroundScripts,
- std::move(scripts));
+ extensions::manifest_keys::kPlatformAppBackgroundScripts, scripts);
extensions::TestExtensionSystem* extension_system(
static_cast<extensions::TestExtensionSystem*>(
@@ -372,9 +371,9 @@
"for testing pinned Gmail");
manifest_gmail.SetString(extensions::manifest_keys::kLaunchWebURL,
kGmailLaunchURL);
- auto list = base::MakeUnique<base::ListValue>();
+ base::ListValue* list = new base::ListValue();
list->AppendString("*://mail.google.com/mail/ca");
- manifest_gmail.Set(extensions::manifest_keys::kWebURLs, std::move(list));
+ manifest_gmail.Set(extensions::manifest_keys::kWebURLs, list);
extension3_ = Extension::Create(base::FilePath(), Manifest::UNPACKED,
manifest_gmail, Extension::NO_FLAGS,
« no previous file with comments | « chrome/browser/ui/ash/chrome_launcher_prefs.cc ('k') | chrome/browser/ui/browser_window_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698