|
Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5 id:80001 of https://codereview.chromium.org/2812953002/ )
Reason for revert:
Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhYWM0NzFjYzczOTQyNDliMWEzZDMyYTc3N2QwNTM5YzJhZTU0ZDUM
Original issue's description:
> Stop passing raw pointers to base::Value API in c/b/ui
>
> Passing ownership of base::Value into API methods DictionaryValue::Set,
> DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> pointers is deprecated, can hide bugs and should be done via unique_ptr
> instead.
>
> Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
>
> BUG= 581865
> TBR=dbeam@chromium.org
>
> Review-Url: https://codereview.chromium.org/2812953002
> Cr-Commit-Position: refs/heads/master@{#464860}
> Committed: https://chromium.googlesource.com/chromium/src/+/4aac471cc7394249b1a3d32a777d0539c2ae54d5
TBR=derat@chromium.org,estade@chromium.org,jdoerrie@chromium.org,msw@chromium.org,dpapad@chromium.org,dbeam@chromium.org,vabr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 581865
Review-Url: https://codereview.chromium.org/2820823005
Cr-Commit-Position: refs/heads/master@{#464867}
Committed: https://chromium.googlesource.com/chromium/src/+/9a351077393017cd8e0286942e2539144207e10f
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+299 lines, -359 lines) |
Patch |
|
M |
chrome/browser/chromeos/proxy_cros_settings_parser.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/proxy_cros_settings_parser.cc
|
View
|
|
3 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/app_list/search/common/webservice_cache.h
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/app_list/search/common/webservice_cache.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/ash/chrome_launcher_prefs.cc
|
View
|
|
2 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
|
View
|
|
2 chunks |
+5 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/browser_window_state.cc
|
View
|
|
2 chunks |
+5 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/browsing_history_handler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc
|
View
|
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/login/network_screen_handler.h
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc
|
View
|
|
3 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/network_ui.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/power_ui.cc
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chromeos/set_time_ui.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/components_ui.h
|
View
|
|
3 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/components_ui.cc
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/cookies_tree_model_util.cc
|
View
|
|
4 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/extensions/extension_loader_handler.cc
|
View
|
|
2 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/flags_ui.cc
|
View
|
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/flash_ui.cc
|
View
|
|
5 chunks |
+36 lines, -32 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/foreign_session_handler.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/identity_internals_ui.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/instant_ui.cc
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
|
View
|
|
3 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/nacl_ui.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/ntp/app_launcher_handler.cc
|
View
|
|
6 chunks |
+12 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/autofill_options_handler.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/browser_options_handler.cc
|
View
|
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/certificate_manager_handler.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
|
View
|
|
7 chunks |
+16 lines, -17 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h
|
View
|
|
3 chunks |
+2 lines, -8 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
|
View
|
|
6 chunks |
+14 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
|
View
|
|
3 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/clear_browser_data_handler.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/core_options_handler.h
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/core_options_handler.cc
|
View
|
|
6 chunks |
+9 lines, -11 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/handler_options_handler.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/language_options_handler.h
|
View
|
|
2 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/language_options_handler.cc
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/language_options_handler_common.h
|
View
|
|
3 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/language_options_handler_common.cc
|
View
|
|
4 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/search_engine_manager_handler.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/options/supervised_user_import_handler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/policy_ui_handler.cc
|
View
|
|
6 chunks |
+22 lines, -22 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/predictors/predictors_handler.cc
|
View
|
|
6 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/settings/certificates_handler.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/settings/search_engines_handler.cc
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
|
View
|
|
4 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/system_info_ui.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
|
View
|
|
6 chunks |
+31 lines, -31 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/voice_search_ui.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/ui/zoom/chrome_zoom_level_prefs.cc
|
View
|
|
2 chunks |
+10 lines, -17 lines |
0 comments
|
Download
|
Total messages: 11 (4 generated)
|