Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2459)

Unified Diff: chrome/browser/ui/webui/foreign_session_handler.cc

Issue 2820823005: Revert of Stop passing raw pointers to base::Value API in c/b/ui (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/flash_ui.cc ('k') | chrome/browser/ui/webui/identity_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/foreign_session_handler.cc
diff --git a/chrome/browser/ui/webui/foreign_session_handler.cc b/chrome/browser/ui/webui/foreign_session_handler.cc
index 425ffff9c0ab71cfdfe64ece71034bb5c91d6ad6..d8b1c255e03717dd5e3fe7221673cacb2e64a892 100644
--- a/chrome/browser/ui/webui/foreign_session_handler.cc
+++ b/chrome/browser/ui/webui/foreign_session_handler.cc
@@ -121,7 +121,7 @@
return nullptr;
std::unique_ptr<base::DictionaryValue> dictionary(
BuildWindowData(window.timestamp, window.window_id.id()));
- dictionary->Set("tabs", std::move(tab_values));
+ dictionary->Set("tabs", tab_values.release());
return dictionary;
}
@@ -323,12 +323,12 @@
if (tab_values->GetSize() != 0) {
std::unique_ptr<base::DictionaryValue> window_data(
BuildWindowData(modification_time, 1));
- window_data->Set("tabs", std::move(tab_values));
+ window_data->Set("tabs", tab_values.release());
window_list->Append(std::move(window_data));
}
}
- session_data->Set("windows", std::move(window_list));
+ session_data->Set("windows", window_list.release());
session_list.Append(std::move(session_data));
}
}
« no previous file with comments | « chrome/browser/ui/webui/flash_ui.cc ('k') | chrome/browser/ui/webui/identity_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698