Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2820113004: Revert of [gin] Add Arguments::GetAll() (Closed)

Created:
3 years, 8 months ago by ojan
Modified:
3 years, 8 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [gin] Add Arguments::GetAll() (patchset #1 id:1 of https://codereview.chromium.org/2824883002/ ) Reason for revert: Broke Win64 Compile: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10538 Original issue's description: > [gin] Add Arguments::GetAll() > > Add an Arguments::GetAll() function that returns all arguments as a > std::vector<v8::Local<v8::Value>>. This is more clear, concise, and > slightly more performant than the alternative of using > Arguments::GetRemaining() since it doesn't require trying to convert > and avoids unnecessary calls. > > Add a test for the new method. > > BUG=None > > Review-Url: https://codereview.chromium.org/2824883002 > Cr-Commit-Position: refs/heads/master@{#465253} > Committed: https://chromium.googlesource.com/chromium/src/+/3853b0bd67adec1b98b222196b89aca2468b9fe2 TBR=jochen@chromium.org,rdevlin.cronin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2820113004 Cr-Commit-Position: refs/heads/master@{#465268} Committed: https://chromium.googlesource.com/chromium/src/+/b3945afe45f51d444701d479358e8bae4ab18272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -82 lines) Patch
M extensions/renderer/event_emitter.cc View 1 chunk +5 lines, -1 line 0 comments Download
M gin/arguments.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gin/arguments.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M gin/arguments_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ojan
Created Revert of [gin] Add Arguments::GetAll()
3 years, 8 months ago (2017-04-18 17:07:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820113004/1
3 years, 8 months ago (2017-04-18 17:08:12 UTC) #3
Roger McFarlane (Chromium)
lgtm
3 years, 8 months ago (2017-04-18 17:08:19 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 17:08:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3945afe45f51d444701d479358e...

Powered by Google App Engine
This is Rietveld 408576698