DescriptionRevert of [gin] Add Arguments::GetAll() (patchset #1 id:1 of https://codereview.chromium.org/2824883002/ )
Reason for revert:
Broke Win64 Compile: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10538
Original issue's description:
> [gin] Add Arguments::GetAll()
>
> Add an Arguments::GetAll() function that returns all arguments as a
> std::vector<v8::Local<v8::Value>>. This is more clear, concise, and
> slightly more performant than the alternative of using
> Arguments::GetRemaining() since it doesn't require trying to convert
> and avoids unnecessary calls.
>
> Add a test for the new method.
>
> BUG=None
>
> Review-Url: https://codereview.chromium.org/2824883002
> Cr-Commit-Position: refs/heads/master@{#465253}
> Committed: https://chromium.googlesource.com/chromium/src/+/3853b0bd67adec1b98b222196b89aca2468b9fe2
TBR=jochen@chromium.org,rdevlin.cronin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review-Url: https://codereview.chromium.org/2820113004
Cr-Commit-Position: refs/heads/master@{#465268}
Committed: https://chromium.googlesource.com/chromium/src/+/b3945afe45f51d444701d479358e8bae4ab18272
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|