Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gin/arguments.h

Issue 2820113004: Revert of [gin] Add Arguments::GetAll() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/event_emitter.cc ('k') | gin/arguments.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/arguments.h
diff --git a/gin/arguments.h b/gin/arguments.h
index c0a7bc2171d4fd51d2d794b47038484716a493a4..99a5d16db21c388dc5dc859301e8deb85cc1c1fd 100644
--- a/gin/arguments.h
+++ b/gin/arguments.h
@@ -81,11 +81,6 @@
// dereferencing the handle.
v8::Local<v8::Value> PeekNext() const;
- // Returns all arguments. Since this doesn't require any conversion, it
- // cannot fail. This does not rely on or modify the current position in the
- // array used by Get/PeekNext().
- std::vector<v8::Local<v8::Value>> GetAll() const;
-
void ThrowError() const;
void ThrowTypeError(const std::string& message) const;
« no previous file with comments | « extensions/renderer/event_emitter.cc ('k') | gin/arguments.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698