Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2824883002: [gin] Add Arguments::GetAll() (Closed)

Created:
3 years, 8 months ago by Devlin
Modified:
3 years, 8 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, jbroman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[gin] Add Arguments::GetAll() Add an Arguments::GetAll() function that returns all arguments as a std::vector<v8::Local<v8::Value>>. This is more clear, concise, and slightly more performant than the alternative of using Arguments::GetRemaining() since it doesn't require trying to convert and avoids unnecessary calls. Add a test for the new method. BUG=None Review-Url: https://codereview.chromium.org/2824883002 Cr-Commit-Position: refs/heads/master@{#465253} Committed: https://chromium.googlesource.com/chromium/src/+/3853b0bd67adec1b98b222196b89aca2468b9fe2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -5 lines) Patch
M extensions/renderer/event_emitter.cc View 1 chunk +1 line, -5 lines 1 comment Download
M gin/arguments.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gin/arguments.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M gin/arguments_unittest.cc View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
Jochen, mind taking a look? jbroman@, fyi. https://codereview.chromium.org/2824883002/diff/1/extensions/renderer/event_emitter.cc File extensions/renderer/event_emitter.cc (right): https://codereview.chromium.org/2824883002/diff/1/extensions/renderer/event_emitter.cc#newcode133 extensions/renderer/event_emitter.cc:133: std::vector<v8::Local<v8::Value>> v8_args ...
3 years, 8 months ago (2017-04-17 21:55:18 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-18 10:52:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824883002/1
3 years, 8 months ago (2017-04-18 15:24:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/3853b0bd67adec1b98b222196b89aca2468b9fe2
3 years, 8 months ago (2017-04-18 16:06:24 UTC) #11
ojan
3 years, 8 months ago (2017-04-18 17:07:44 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2820113004/ by ojan@chromium.org.

The reason for reverting is: Broke Win64 Compile:
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10538.

Powered by Google App Engine
This is Rietveld 408576698