Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: gin/arguments.cc

Issue 2820113004: Revert of [gin] Add Arguments::GetAll() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/arguments.h ('k') | gin/arguments_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/arguments.cc
diff --git a/gin/arguments.cc b/gin/arguments.cc
index 4d01c0e44d9bce5b818b830f3499ccf6f4a07f96..600a811f8483bb0fa77be9156c7c4578a5099167 100644
--- a/gin/arguments.cc
+++ b/gin/arguments.cc
@@ -30,19 +30,6 @@
if (next_ >= info_->Length())
return v8::Local<v8::Value>();
return (*info_)[next_];
-}
-
-std::vector<v8::Local<v8::Value>> Arguments::GetAll() const {
- std::vector<v8::Local<v8::Value>> result;
- int length = info_->Length();
- if (length == 0)
- return result;
-
- result.reserve(length);
- for (int i = 0; i < length; ++i)
- result.push_back((*info_)[i]);
-
- return result;
}
v8::Local<v8::Context> Arguments::GetHolderCreationContext() {
« no previous file with comments | « gin/arguments.h ('k') | gin/arguments_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698