Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/heap

Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/heap

Replace RELEASE_ASSERT, and ASSERT_NOT_REACHED
with CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/heap

BUG=707659
Review-Url: https://codereview.chromium.org/2819123002
Cr-Commit-Position: refs/heads/master@{#464887}
Committed: https://chromium.googlesource.com/chromium/src/+/cd4f72fdeae5d12e0c7c4efc0a1a0e1d7af1e0ba

[Hwanseung Lee, 2017-04-16 08:25:48]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 08:25:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 08:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 08:46:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Hwanseung Lee, 2017-04-16 08:57:10]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 08:57:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-04-16 09:59:26]

hs1217.lee@samsung.com changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[Hwanseung Lee, 2017-04-16 09:59:26]

PTAL, thank you.

https://codereview.chromium.org/2819123002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/GCInfo.cpp (right):

https://codereview.chromium.org/2819123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/GCInfo.cpp:35: CHECK(gc_info_index <
GCInfoTable::kMaxIndex);
when replace to CHECK_LT, it makes build fail.

[commit-bot: I haz the power, 2017-04-16 10:25:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 10:25:33]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-04-16 10:54:35]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-04-16 10:54:36]

lgtm

[commit-bot: I haz the power, 2017-04-16 10:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 10:59:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492340075726040,
"parent_rev": "3c5671cbd98d7abafc992e09126b678c70705847", "commit_rev":
"cd4f72fdeae5d12e0c7c4efc0a1a0e1d7af1e0ba"}

[commit-bot: I haz the power, 2017-04-16 11:00:57]

Description was changed from

==========
Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/heap

Replace RELEASE_ASSERT, and ASSERT_NOT_REACHED
with CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/heap

BUG=707659
==========

to

==========
Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/heap

Replace RELEASE_ASSERT, and ASSERT_NOT_REACHED
with CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/platform/heap

BUG=707659

Review-Url: https://codereview.chromium.org/2819123002
Cr-Commit-Position: refs/heads/master@{#464887}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd4f72fdeae5d12e0c7c4efc0a1a...
==========

[commit-bot: I haz the power, 2017-04-16 11:00:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cd4f72fdeae5d12e0c7c4efc0a1a...

[sof, 2017-04-16 14:33:11]

https://codereview.chromium.org/2819123002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/GCInfo.cpp (right):

https://codereview.chromium.org/2819123002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/GCInfo.cpp:35: CHECK(gc_info_index <
GCInfoTable::kMaxIndex);
On 2017/04/16 09:59:26, Hwanseung Lee wrote:
> when replace to CHECK_LT, it makes build fail.

Marking GCInfoTable as |final| would have avoided that failure across
toolchains, i think.

[haraken, 2017-04-16 15:52:54]

LGTM