Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/heap

third_party/WebKit/Source/platform/heap/GCInfo.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/heap/GCInfo.h"
 
 #include "platform/heap/Handle.h"
 #include "platform/heap/Heap.h"
 
 namespace blink {
@@ skipping 14 matching lines @@
   MutexLocker locker(mutex);
 
   // If more than one thread ends up allocating a slot for
   // the same GCInfo, have later threads reuse the slot
   // allocated by the first.
   if (*gc_info_index_slot)
     return;
 
   int index = ++gc_info_index_;
   size_t gc_info_index = static_cast<size_t>(index);
-  RELEASE_ASSERT(gc_info_index < GCInfoTable::kMaxIndex);
+  CHECK(gc_info_index < GCInfoTable::kMaxIndex);

[Hwanseung Lee, 2017/04/16 09:59:26]

when replace to CHECK_LT, it makes build fail.

[sof, 2017/04/16 14:33:11]

Marking GCInfoTable as |final| would have avoided that failure across
toolchains, i think.

   if (gc_info_index >= gc_info_table_size_)
     Resize();
 
   g_gc_info_table[gc_info_index] = gc_info;
   ReleaseStore(reinterpret_cast<int*>(gc_info_index_slot), index);
 }
 
 void GCInfoTable::Resize() {
   static const int kGcInfoZapValue = 0x33;
   // (Light) experimentation suggests that Blink doesn't need
   // more than this while handling content on popular web properties.
   const size_t kInitialSize = 512;
 
   size_t new_size =
       gc_info_table_size_ ? 2 * gc_info_table_size_ : kInitialSize;
   ASSERT(new_size < GCInfoTable::kMaxIndex);
   g_gc_info_table =
       reinterpret_cast<GCInfo const**>(WTF::Partitions::FastRealloc(
           g_gc_info_table, new_size * sizeof(GCInfo), "GCInfo"));
   ASSERT(g_gc_info_table);
   memset(reinterpret_cast<uint8_t*>(g_gc_info_table) +
              gc_info_table_size_ * sizeof(GCInfo),
          kGcInfoZapValue, (new_size - gc_info_table_size_) * sizeof(GCInfo));
   gc_info_table_size_ = new_size;
 }
 
 void GCInfoTable::Init() {
-  RELEASE_ASSERT(!g_gc_info_table);
+  CHECK(!g_gc_info_table);
   Resize();
 }
 
 #if DCHECK_IS_ON()
 void AssertObjectHasGCInfo(const void* payload, size_t gc_info_index) {
   HeapObjectHeader::CheckFromPayload(payload);
 #if !defined(COMPONENT_BUILD)
   // On component builds we cannot compare the gcInfos as they are statically
   // defined in each of the components and hence will not match.
   ASSERT(HeapObjectHeader::FromPayload(payload)->GcInfoIndex() ==
          gc_info_index);
 #endif
 }
 #endif
 
 }  // namespace blink