Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: third_party/WebKit/Source/platform/heap/GCInfo.cpp

Issue 2819123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/heap (Closed)
Patch Set: fix build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/Heap.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/GCInfo.cpp
diff --git a/third_party/WebKit/Source/platform/heap/GCInfo.cpp b/third_party/WebKit/Source/platform/heap/GCInfo.cpp
index 74e694c96f9b3be2e71cb1b1adaaa28faddd7c10..2f4a425ac3bca04a29657ae64303efed0f6f0f20 100644
--- a/third_party/WebKit/Source/platform/heap/GCInfo.cpp
+++ b/third_party/WebKit/Source/platform/heap/GCInfo.cpp
@@ -32,7 +32,7 @@ void GCInfoTable::EnsureGCInfoIndex(const GCInfo* gc_info,
int index = ++gc_info_index_;
size_t gc_info_index = static_cast<size_t>(index);
- RELEASE_ASSERT(gc_info_index < GCInfoTable::kMaxIndex);
+ CHECK(gc_info_index < GCInfoTable::kMaxIndex);
Hwanseung Lee 2017/04/16 09:59:26 when replace to CHECK_LT, it makes build fail.
sof 2017/04/16 14:33:11 Marking GCInfoTable as |final| would have avoided
if (gc_info_index >= gc_info_table_size_)
Resize();
@@ -60,7 +60,7 @@ void GCInfoTable::Resize() {
}
void GCInfoTable::Init() {
- RELEASE_ASSERT(!g_gc_info_table);
+ CHECK(!g_gc_info_table);
Resize();
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/Heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698