Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: third_party/WebKit/Source/platform/heap/Heap.h

Issue 2819123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/heap (Closed)
Patch Set: fix build error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/Heap.h
diff --git a/third_party/WebKit/Source/platform/heap/Heap.h b/third_party/WebKit/Source/platform/heap/Heap.h
index 93edfbc817cfcb203743c3d55867fcb865d19b00..0a9ec910d32c772cb898cc816dc1b68aa295f19f 100644
--- a/third_party/WebKit/Source/platform/heap/Heap.h
+++ b/third_party/WebKit/Source/platform/heap/Heap.h
@@ -379,7 +379,7 @@ class PLATFORM_EXPORT ThreadHeap {
// Add space for header.
size_t allocation_size = size + sizeof(HeapObjectHeader);
// The allocation size calculation can overflow for large sizes.
- RELEASE_ASSERT(allocation_size > size);
+ CHECK_GT(allocation_size, size);
// Align size with allocation granularity.
allocation_size = (allocation_size + kAllocationMask) & ~kAllocationMask;
return allocation_size;
@@ -493,7 +493,7 @@ class GarbageCollected {
// the delete[] operator in the GarbageCollected subclasses as it
// is called when a class is exported in a DLL.
protected:
- void operator delete[](void* p) { ASSERT_NOT_REACHED(); }
+ void operator delete[](void* p) { NOTREACHED(); }
#else
void operator delete[](void* p);
#endif
@@ -509,7 +509,7 @@ class GarbageCollected {
return ThreadHeap::Allocate<T>(size, eagerly_sweep);
}
- void operator delete(void* p) { ASSERT_NOT_REACHED(); }
+ void operator delete(void* p) { NOTREACHED(); }
protected:
GarbageCollected() {}

Powered by Google App Engine
This is Rietveld 408576698