Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2818013002: [Media] Add a feature flag to pause bg video only players. (Closed)

Created:
3 years, 8 months ago by whywhat
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media] Add a feature flag to pause bg video only players. BUG=663999 TEST=manual+unittests Review-Url: https://codereview.chromium.org/2818013002 Cr-Commit-Position: refs/heads/master@{#464624} Committed: https://chromium.googlesource.com/chromium/src/+/0120133fb866f23b66a32b39def84ed41d26d69b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M media/base/media_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 7 chunks +21 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
whywhat
PTaL
3 years, 8 months ago (2017-04-13 21:54:35 UTC) #2
DaleCurtis
What's this one for? lgtm in any case
3 years, 8 months ago (2017-04-13 22:06:01 UTC) #5
whywhat
On 2017/04/13 at 22:06:01, dalecurtis wrote: > What's this one for? lgtm in any case ...
3 years, 8 months ago (2017-04-13 23:34:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818013002/1
3 years, 8 months ago (2017-04-14 00:17:01 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 00:28:33 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0120133fb866f23b66a32b39def8...

Powered by Google App Engine
This is Rietveld 408576698