Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2810333007: [Video] Record the results of background video optimization checks.

Created:
3 years, 8 months ago by whywhat
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
apacible+watch_chromium.org, asvitkine+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Video] Record the results of background video optimization checks. Each time we check whether to pause or disable video for backgrounded media elements, record the result along with the reason. BUG=None TEST=manual

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -8 lines) Patch
M media/blink/webmediaplayer_impl.h View 1 chunk +27 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +53 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +29 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (1 generated)
whywhat
PTaL Some caveats: - we will record something anytime when IsBackgroundOptimizationCandidate is called, even if ...
3 years, 8 months ago (2017-04-14 00:09:44 UTC) #2
DaleCurtis
3 years, 8 months ago (2017-04-14 01:21:55 UTC) #3
Hmm, what are we trying to solve here? Or are you just trying to figure out the
number of times we'd actually try to optimize? code-wise lgtm, but not sure what
we'll get out of it.

Powered by Google App Engine
This is Rietveld 408576698