[Media] Add a feature flag to pause bg video only players.

media/blink/webmediaplayer_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <stdint.h>
 
 #include <memory>
 
@@ skipping 791 matching lines @@
   EXPECT_FALSE(IsIdlePauseTimerRunning());
 
   SetMetadata(true, true);
   ScheduleIdlePauseTimer();
   EXPECT_TRUE(IsIdlePauseTimerRunning());
 }
 
 class WebMediaPlayerImplBackgroundBehaviorTest
     : public WebMediaPlayerImplTest,
       public ::testing::WithParamInterface<
-          std::tuple<bool, bool, int, int, bool, bool>> {
+          std::tuple<bool, bool, int, int, bool, bool, bool>> {
  public:
   // Indices of the tuple parameters.
   static const int kIsMediaSuspendEnabled = 0;
   static const int kIsBackgroundOptimizationEnabled = 1;
   static const int kDurationSec = 2;
   static const int kAverageKeyframeDistanceSec = 3;
   static const int kIsResumeBackgroundVideoEnabled = 4;
   static const int kIsMediaSource = 5;
+  static const int kIsBackgroundPauseEnabled = 6;
 
   void SetUp() override {
     WebMediaPlayerImplTest::SetUp();
 
     SetUpMediaSuspend(IsMediaSuspendOn());
 
     std::string enabled_features;
     std::string disabled_features;
     if (IsBackgroundOptimizationOn()) {
       enabled_features += kBackgroundVideoTrackOptimization.name;
     } else {
       disabled_features += kBackgroundVideoTrackOptimization.name;
     }
 
+    if (IsBackgroundPauseOn()) {
+      if (!enabled_features.empty())
+        enabled_features += ",";
+      enabled_features += kBackgroundVideoPauseOptimization.name;
+    } else {
+      if (!disabled_features.empty())
+        disabled_features += ",";
+      disabled_features += kBackgroundVideoPauseOptimization.name;
+    }
+
     if (IsResumeBackgroundVideoEnabled()) {
       if (!enabled_features.empty())
         enabled_features += ",";
       enabled_features += kResumeBackgroundVideo.name;
     } else {
       if (!disabled_features.empty())
         disabled_features += ",";
       disabled_features += kResumeBackgroundVideo.name;
     }
 
@@ skipping 24 matching lines @@
   }
 
   bool IsBackgroundOptimizationOn() {
     return std::get<kIsBackgroundOptimizationEnabled>(GetParam());
   }
 
   bool IsResumeBackgroundVideoEnabled() {
     return std::get<kIsResumeBackgroundVideoEnabled>(GetParam());
   }
 
+  bool IsBackgroundPauseOn() {
+    return std::get<kIsBackgroundPauseEnabled>(GetParam());
+  }
+
   int GetDurationSec() const { return std::get<kDurationSec>(GetParam()); }
 
   int GetAverageKeyframeDistanceSec() const {
     return std::get<kAverageKeyframeDistanceSec>(GetParam());
   }
 
   int GetMaxKeyframeDistanceSec() const {
     base::TimeDelta max_keyframe_distance =
         std::get<kIsMediaSource>(GetParam())
             ? kMaxKeyframeDistanceToDisableBackgroundVideoMSE
@@ skipping 42 matching lines @@
 
   // There's no optimization criteria for video only on Android.
   bool matches_requirements =
       IsAndroid() ||
       ((GetDurationSec() < GetMaxKeyframeDistanceSec()) ||
        (GetAverageKeyframeDistanceSec() < GetMaxKeyframeDistanceSec()));
   EXPECT_EQ(matches_requirements, IsBackgroundOptimizationCandidate());
 
   // Video is always paused when suspension is on and only if matches the
   // optimization criteria if the optimization is on.
-  bool should_pause = IsMediaSuspendOn() ||
-                      (IsBackgroundOptimizationOn() && matches_requirements);
+  bool should_pause =
+      IsMediaSuspendOn() || (IsBackgroundPauseOn() && matches_requirements);
   EXPECT_EQ(should_pause, ShouldPauseVideoWhenHidden());
 }
 
 TEST_P(WebMediaPlayerImplBackgroundBehaviorTest, AudioVideo) {
   SetMetadata(true, true);
 
   // Optimization requirements are the same for all platforms.
   bool matches_requirements =
       (GetDurationSec() < GetMaxKeyframeDistanceSec()) ||
       (GetAverageKeyframeDistanceSec() < GetMaxKeyframeDistanceSec());
 
   EXPECT_EQ(matches_requirements, IsBackgroundOptimizationCandidate());
   EXPECT_EQ(IsBackgroundOptimizationOn() && matches_requirements,
             ShouldDisableVideoWhenHidden());
 
-  // Only pause audible videos on Android if both media suspend and resume
-  // background videos is on. On Desktop
+  // Only pause audible videos if both media suspend and resume background
+  // videos is on. Both are on by default on Android and off on desktop.
   EXPECT_EQ(IsMediaSuspendOn() && IsResumeBackgroundVideoEnabled(),
             ShouldPauseVideoWhenHidden());
 }
 
 INSTANTIATE_TEST_CASE_P(BackgroundBehaviorTestInstances,
                         WebMediaPlayerImplBackgroundBehaviorTest,
                         ::testing::Combine(::testing::Bool(),
                                            ::testing::Bool(),
                                            ::testing::Values(5, 300),
                                            ::testing::Values(5, 100),
                                            ::testing::Bool(),
+                                           ::testing::Bool(),
                                            ::testing::Bool()));
 
 }  // namespace media