Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2818823002: [Media] Add a finch trial param for background MediaSource videos (Closed)

Created:
3 years, 8 months ago by whywhat
Modified:
3 years, 8 months ago
Reviewers:
jam, DaleCurtis
CC:
apacible+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, erickung+watch_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media] Add a finch trial param for background MediaSource videos Added a new finch trial parameter to set the max average keyframe distance that allows disabling of the video track or pausing MediaSource videos when in the background. WMPI now uses the right parameter according to the |load_type_|. Parametrized unit tests test for both load types. BUG=663999 TEST=unittests+manual Review-Url: https://codereview.chromium.org/2818823002 Cr-Commit-Position: refs/heads/master@{#464619} Committed: https://chromium.googlesource.com/chromium/src/+/e85ec428376cf7d6f281ace33f1a8b440dc601c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -10 lines) Patch
M content/renderer/render_frame_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +5 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 11 chunks +32 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_params.h View 3 chunks +7 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_params.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
whywhat
PTaL
3 years, 8 months ago (2017-04-13 20:57:15 UTC) #2
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-13 21:26:29 UTC) #3
jam
content lgtm
3 years, 8 months ago (2017-04-13 23:12:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818823002/1
3 years, 8 months ago (2017-04-14 00:04:19 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 00:13:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e85ec428376cf7d6f281ace33f1a...

Powered by Google App Engine
This is Rietveld 408576698