Shorten FrameSelection::IsAppearanceDirty() call stack

Shorten FrameSelection::IsAppearanceDirty() call stack

IsAppearanceDirty() is called only from FrameView.cpp so call it directly
 w/o Layout API.
Also rename it to NeedsLayoutSelectionUpdate().

BUG=708453
Review-Url: https://codereview.chromium.org/2816953002
Cr-Commit-Position: refs/heads/master@{#464653}
Committed: https://chromium.googlesource.com/chromium/src/+/a1bd9cb4fe2557db40620f62766eb2e111b12de1

[yoichio, 2017-04-13 07:13:01]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 07:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-04-13 08:21:49]

Description was changed from

==========
Shorten haspendinselection calling

BUG=708453
==========

to

==========
Shorten FrameSelection::IsAppearanceDirty() call stack

IsAppearanceDirty() is called only from FrameView.cpp so call it directly
 w/o Layout API.
Also rename it to IsLayoutSelectionNeedsUpdate.

BTW, this is called only in DCHECK(). How might we define in #ifdef NDEBUG?

BUG=708453
==========

[yoichio, 2017-04-13 08:21:49]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yosin_UTC9, 2017-04-13 09:00:34]

Cool!

https://codereview.chromium.org/2816953002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelection.h (right):

https://codereview.chromium.org/2816953002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelection.h:186: bool
IsLayoutSelectionNeedsUpdate() const;
nit: s/IsLayoutSelectionNeedsUpdate()/NeedsLayoutSelectionUpdate()/
Like |Document::NeedsLayoutTreeUpdate()|,
|Document::NeedsFullLayoutTreeUpdate()|, etc.

[yoichio, 2017-04-13 09:24:10]

https://codereview.chromium.org/2816953002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameSelection.h (right):

https://codereview.chromium.org/2816953002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameSelection.h:186: bool
IsLayoutSelectionNeedsUpdate() const;
On 2017/04/13 09:00:34, yosin_UTC9 wrote:
> nit: s/IsLayoutSelectionNeedsUpdate()/NeedsLayoutSelectionUpdate()/
> Like |Document::NeedsLayoutTreeUpdate()|,
> |Document::NeedsFullLayoutTreeUpdate()|, etc.

Done.

[yoichio, 2017-04-13 09:24:38]

Description was changed from

==========
Shorten FrameSelection::IsAppearanceDirty() call stack

IsAppearanceDirty() is called only from FrameView.cpp so call it directly
 w/o Layout API.
Also rename it to IsLayoutSelectionNeedsUpdate.

BTW, this is called only in DCHECK(). How might we define in #ifdef NDEBUG?

BUG=708453
==========

to

==========
Shorten FrameSelection::IsAppearanceDirty() call stack

IsAppearanceDirty() is called only from FrameView.cpp so call it directly
 w/o Layout API.
Also rename it to NeedsLayoutSelectionUpdate().

BUG=708453
==========

[yosin_UTC9, 2017-04-13 09:32:24]

lgtm

[yoichio, 2017-04-13 10:46:09]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-04-13 10:46:19]

The CQ bit was unchecked by yoichio@chromium.org

[yoichio, 2017-04-13 10:48:26]

yoichio@chromium.org changed reviewers:
+ tkent@chromium.org

[yoichio, 2017-04-13 10:48:27]

Kent, could you stamp on this?

[tkent, 2017-04-13 22:59:19]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-04-13 22:59:20]

lgtm

[commit-bot: I haz the power, 2017-04-13 23:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 00:29:19]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492124359868630,
"parent_rev": "0120133fb866f23b66a32b39def84ed41d26d69b", "commit_rev":
"b9bbb8a12fcb694ce7f50509a71403b497e2b23b"}

[commit-bot: I haz the power, 2017-04-14 00:44:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 00:44:53]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[yoichio, 2017-04-14 01:46:28]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2017-04-14 01:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 01:51:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492134388015270,
"parent_rev": "ac6c649536f9df08ffbff483052bb3b4782bd682", "commit_rev":
"a1bd9cb4fe2557db40620f62766eb2e111b12de1"}

[commit-bot: I haz the power, 2017-04-14 01:52:46]

Description was changed from

==========
Shorten FrameSelection::IsAppearanceDirty() call stack

IsAppearanceDirty() is called only from FrameView.cpp so call it directly
 w/o Layout API.
Also rename it to NeedsLayoutSelectionUpdate().

BUG=708453
==========

to

==========
Shorten FrameSelection::IsAppearanceDirty() call stack

IsAppearanceDirty() is called only from FrameView.cpp so call it directly
 w/o Layout API.
Also rename it to NeedsLayoutSelectionUpdate().

BUG=708453

Review-Url: https://codereview.chromium.org/2816953002
Cr-Commit-Position: refs/heads/master@{#464653}
Committed:
https://chromium.googlesource.com/chromium/src/+/a1bd9cb4fe2557db40620f62766e...
==========

[commit-bot: I haz the power, 2017-04-14 01:52:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a1bd9cb4fe2557db40620f62766e...