Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack (Closed)
Patch Set: update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 879 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 // invalidations. 890 // invalidations.
891 DisableCompositingQueryAsserts disabler; 891 DisableCompositingQueryAsserts disabler;
892 892
893 SetSelection(0, -1, 0, -1, kPaintInvalidationNewMinusOld); 893 SetSelection(0, -1, 0, -1, kPaintInvalidationNewMinusOld);
894 } 894 }
895 895
896 void LayoutView::ClearSelection() { 896 void LayoutView::ClearSelection() {
897 frame_view_->GetFrame().Selection().ClearLayoutSelection(); 897 frame_view_->GetFrame().Selection().ClearLayoutSelection();
898 } 898 }
899 899
900 bool LayoutView::HasPendingSelection() const {
901 return frame_view_->GetFrame().Selection().IsAppearanceDirty();
902 }
903
904 void LayoutView::CommitPendingSelection() { 900 void LayoutView::CommitPendingSelection() {
905 TRACE_EVENT0("blink", "LayoutView::commitPendingSelection"); 901 TRACE_EVENT0("blink", "LayoutView::commitPendingSelection");
906 frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded(*this); 902 frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded(*this);
907 } 903 }
908 904
909 void LayoutView::SelectionStartEnd(int& start_pos, int& end_pos) { 905 void LayoutView::SelectionStartEnd(int& start_pos, int& end_pos) {
910 frame_view_->GetFrame().Selection().LayoutSelectionStartEnd(start_pos, 906 frame_view_->GetFrame().Selection().LayoutSelectionStartEnd(start_pos,
911 end_pos); 907 end_pos);
912 } 908 }
913 909
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
1113 // Frame scroll corner is painted using LayoutView as the display item client. 1109 // Frame scroll corner is painted using LayoutView as the display item client.
1114 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() && 1110 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
1115 (GetFrameView()->HorizontalScrollbar() || 1111 (GetFrameView()->HorizontalScrollbar() ||
1116 GetFrameView()->VerticalScrollbar())) 1112 GetFrameView()->VerticalScrollbar()))
1117 return false; 1113 return false;
1118 1114
1119 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize(); 1115 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize();
1120 } 1116 }
1121 1117
1122 } // namespace blink 1118 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.h ('k') | third_party/WebKit/Source/core/layout/api/LayoutViewItem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698