third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack (Closed)

Patch Set: update Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index 22314dc7eeb4dd3d1cd2f2540c41434e4982c56a..0d8f6a3b098d898865d1b0a561551513af431a06 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -897,10 +897,6 @@ void LayoutView::ClearSelection() {

frame_view_->GetFrame().Selection().ClearLayoutSelection();

}

-bool LayoutView::HasPendingSelection() const {

- return frame_view_->GetFrame().Selection().IsAppearanceDirty();

void LayoutView::CommitPendingSelection() {

TRACE_EVENT0("blink", "LayoutView::commitPendingSelection");

frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded(*this);