Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2816953002: Shorten FrameSelection::IsAppearanceDirty() call stack (Closed)
Patch Set: update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 IntRect AbsoluteCaretBounds(); 176 IntRect AbsoluteCaretBounds();
177 177
178 void DidChangeFocus(); 178 void DidChangeFocus();
179 179
180 const SelectionInDOMTree& GetSelectionInDOMTree() const; 180 const SelectionInDOMTree& GetSelectionInDOMTree() const;
181 bool IsDirectional() const { return GetSelectionInDOMTree().IsDirectional(); } 181 bool IsDirectional() const { return GetSelectionInDOMTree().IsDirectional(); }
182 182
183 void DocumentAttached(Document*); 183 void DocumentAttached(Document*);
184 184
185 void DidLayout(); 185 void DidLayout();
186 bool IsAppearanceDirty() const; 186 bool NeedsLayoutSelectionUpdate() const;
187 void CommitAppearanceIfNeeded(LayoutView&); 187 void CommitAppearanceIfNeeded(LayoutView&);
188 void SetCaretVisible(bool caret_is_visible); 188 void SetCaretVisible(bool caret_is_visible);
189 void ScheduleVisualUpdate() const; 189 void ScheduleVisualUpdate() const;
190 void ScheduleVisualUpdateForPaintInvalidationIfNeeded() const; 190 void ScheduleVisualUpdateForPaintInvalidationIfNeeded() const;
191 191
192 // Paint invalidation methods delegating to FrameCaret. 192 // Paint invalidation methods delegating to FrameCaret.
193 void ClearPreviousCaretVisualRect(const LayoutBlock&); 193 void ClearPreviousCaretVisualRect(const LayoutBlock&);
194 void LayoutBlockWillBeDestroyed(const LayoutBlock&); 194 void LayoutBlockWillBeDestroyed(const LayoutBlock&);
195 void UpdateStyleAndLayoutIfNeeded(); 195 void UpdateStyleAndLayoutIfNeeded();
196 void InvalidatePaintIfNeeded(const LayoutBlock&, 196 void InvalidatePaintIfNeeded(const LayoutBlock&,
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 312
313 } // namespace blink 313 } // namespace blink
314 314
315 #ifndef NDEBUG 315 #ifndef NDEBUG
316 // Outside the WebCore namespace for ease of invocation from gdb. 316 // Outside the WebCore namespace for ease of invocation from gdb.
317 void showTree(const blink::FrameSelection&); 317 void showTree(const blink::FrameSelection&);
318 void showTree(const blink::FrameSelection*); 318 void showTree(const blink::FrameSelection*);
319 #endif 319 #endif
320 320
321 #endif // FrameSelection_h 321 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698