Reland of Stop passing raw pointers to base::Value API in c/b/ui

Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1 id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to become:
return std::move(list);

The compilation error was not detected by the basic CQ set, so adding the specific bot below:
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:chromeos_x86-generic_chromium_compile_only_ng

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5 id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhYWM0NzFjYzczOTQyNDliMWEzZDMyYTc3N2QwNTM5YzJhZTU0ZDUM
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@google.com,estade@chromium.org,msw@chromium.org,loyso@google.com,mastiz@google.com,pfeldman@google.com,paulmeyer@google.com,dpapad@chromium.org,findit-for-me@appspot.gserviceaccount.com
BUG=581865
Review-Url: https://codereview.chromium.org/2814363006
Cr-Commit-Position: refs/heads/master@{#464870}
Committed: https://chromium.googlesource.com/chromium/src/+/d092ccd5cf26beafb4c364af453f64293f2b6372

[vabr (Chromium), 2017-04-15 10:25:32]

Created Reland of Stop passing raw pointers to base::Value API in c/b/ui

[vabr (Chromium), 2017-04-15 10:30:15]

Description was changed from

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

Reason for revert:
Creating a reland CL, will add the fix before landing.

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org
> > 
> > Review-Url: https://codereview.chromium.org/2812953002
> > Cr-Commit-Position: refs/heads/master@{#464860}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/4aac471cc7394249b1a3d32a777d...
> 
>
TBR=derat@chromium.org,estade@chromium.org,jdoerrie@chromium.org,msw@chromium...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=581865
> 
> Review-Url: https://codereview.chromium.org/2820823005
> Cr-Commit-Position: refs/heads/master@{#464867}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9a351077393017cd8e0286942e25...

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581865
==========

to

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to
become:
return std::move(list);


Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
BUG=581865
==========

[vabr (Chromium), 2017-04-15 11:16:41]

Description was changed from

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to
become:
return std::move(list);


Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
BUG=581865
==========

to

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to
become:
return std::move(list);

The compilation error was not detected by the basic CQ set, so adding the
specific bot below:
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux.chromeos_x86-generic_chromium_compile_only_ng

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
BUG=581865
==========

[vabr (Chromium), 2017-04-15 11:19:54]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 11:20:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 11:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 11:20:07]

Dry run: Your CL can not be processed by CQ because of:
 * Failed to parse additional trybots

[vabr (Chromium), 2017-04-15 11:27:43]

Hi all,

Sorry for the noise.

The fix is only in
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc (introducing
std::move as explained in the description).

All the other files are the same as in the original CL. None of you needs to
review, except for dbeam@ who might want to look at
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc.

(Rietveld indicates that all files in patch set 2 have a delta against 1, but
that's not true, as can be verified by actually viewing the particular deltas.
The reason is, that the diff for patchset 1 was created by Rietveld's "Revert"
button feature, while the diff for patch set 2 comes from my checkout. They
differ in ordering and unsubstantial meta-data, but when applied, result in the
same changes, except in the above display_options_handler.cc.)

Because the difference against the original CL is so limited and strictly
dictated by the compiler, I will continue landing, using TBR.

Cheers,
Vaclav

[vabr (Chromium), 2017-04-15 11:29:31]

Description was changed from

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to
become:
return std::move(list);

The compilation error was not detected by the basic CQ set, so adding the
specific bot below:
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux.chromeos_x86-generic_chromium_compile_only_ng

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
BUG=581865
==========

to

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to
become:
return std::move(list);

The compilation error was not detected by the basic CQ set, so adding the
specific bot below:
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:chromeos_x86-generic_chromium_compile_only_ng

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
BUG=581865
==========

[vabr (Chromium), 2017-04-15 11:29:45]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 11:29:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-04-15 11:54:11]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2017-04-15 11:54:21]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-04-15 11:54:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 12:16:54]

CQ is committing da patch.

Bot data: {"patchset_id": 300001, "attempt_start_ts": 1492257261291000,
"parent_rev": "a1c43b40dd21a11f9cff2297fc9821c84a893ee8", "commit_rev":
"d092ccd5cf26beafb4c364af453f64293f2b6372"}

[commit-bot: I haz the power, 2017-04-15 12:17:39]

Description was changed from

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to
become:
return std::move(list);

The compilation error was not detected by the basic CQ set, so adding the
specific bot below:
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:chromeos_x86-generic_chromium_compile_only_ng

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
BUG=581865
==========

to

==========
Reland of Stop passing raw pointers to base::Value API in c/b/ui (patchset #1
id:1 of https://codereview.chromium.org/2820823005/ )

The failure was in code like this:
unique_ptr<Value> f() {
  unique_ptr<ListValue> list;
  ...
  return list;
}

Some compilers already support upcasting like this, but for others this needs to
become:
return std::move(list);

The compilation error was not detected by the basic CQ set, so adding the
specific bot below:
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:chromeos_x86-generic_chromium_compile_only_ng

Original issue's description:
> Revert of Stop passing raw pointers to base::Value API in c/b/ui (patchset #5
id:80001 of https://codereview.chromium.org/2812953002/ )
> 
> Reason for revert:
> 
> Findit(https://goo.gl/kROfz5) identified CL at revision 464860 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> Original issue's description:
> > Stop passing raw pointers to base::Value API in c/b/ui
> > 
> > Passing ownership of base::Value into API methods DictionaryValue::Set,
> > DictionaryValue::SetWithoutPathExpansion, and ListValue::Set through raw
> > pointers is deprecated, can hide bugs and should be done via unique_ptr
> > instead.
> > 
> > Therefore, this CL migrates c/b/ui to use the unique_ptr-based API.
> > 
> > BUG=581865
> > TBR=dbeam@chromium.org

TBR=derat@chromium.org,dbeam@chromium.org,jdoerrie@chromium.org,alexmos@googl...
BUG=581865

Review-Url: https://codereview.chromium.org/2814363006
Cr-Commit-Position: refs/heads/master@{#464870}
Committed:
https://chromium.googlesource.com/chromium/src/+/d092ccd5cf26beafb4c364af453f...
==========

[commit-bot: I haz the power, 2017-04-15 12:17:41]

Committed patchset #2 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/d092ccd5cf26beafb4c364af453f...