Reland of Stop passing raw pointers to base::Value API in c/b/ui

chrome/browser/ui/webui/components_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/components_ui.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 86 matching lines @@
                  base::Unretained(this)));
 
   web_ui()->RegisterMessageCallback(
       "checkUpdate",
       base::Bind(&ComponentsDOMHandler::HandleCheckUpdate,
                  base::Unretained(this)));
 }
 
 void ComponentsDOMHandler::HandleRequestComponentsData(
     const base::ListValue* args) {
-  base::ListValue* list = ComponentsUI::LoadComponents();
   base::DictionaryValue result;
-  result.Set("components", list);
+  result.Set("components", ComponentsUI::LoadComponents());
   web_ui()->CallJavascriptFunctionUnsafe("returnComponentsData", result);
 }
 
 // This function is called when user presses button from html UI.
 // TODO(shrikant): We need to make this button available based on current
 // state e.g. If component state is currently updating then we need to disable
 // button. (https://code.google.com/p/chromium/issues/detail?id=272540)
 void ComponentsDOMHandler::HandleCheckUpdate(const base::ListValue* args) {
   if (args->GetSize() != 1) {
     NOTREACHED();
@@ skipping 37 matching lines @@
 
 // static
 void ComponentsUI::OnDemandUpdate(const std::string& component_id) {
   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
   cus->GetOnDemandUpdater().OnDemandUpdate(component_id,
                                            component_updater::Callback());
 }
 
 // static
-base::ListValue* ComponentsUI::LoadComponents() {
+std::unique_ptr<base::ListValue> ComponentsUI::LoadComponents() {
   component_updater::ComponentUpdateService* cus =
       g_browser_process->component_updater();
   std::vector<std::string> component_ids;
   component_ids = cus->GetComponentIDs();
 
   // Construct DictionaryValues to return to UI.
-  base::ListValue* component_list = new base::ListValue();
+  auto component_list = base::MakeUnique<base::ListValue>();
   for (size_t j = 0; j < component_ids.size(); ++j) {
     update_client::CrxUpdateItem item;
     if (cus->GetComponentDetails(component_ids[j], &item)) {
       std::unique_ptr<base::DictionaryValue> component_entry(
           new base::DictionaryValue());
       component_entry->SetString("id", component_ids[j]);
       component_entry->SetString("name", item.component.name);
       component_entry->SetString("version", item.component.version.GetString());
       component_entry->SetString("status", ServiceStatusToString(item.state));
       component_list->Append(std::move(component_entry));
@@ skipping 70 matching lines @@
     if (event == Events::COMPONENT_UPDATED) {
       auto* component_updater = g_browser_process->component_updater();
       update_client::CrxUpdateItem item;
       if (component_updater->GetComponentDetails(id, &item))
         parameters.SetString("version", item.component.version.GetString());
     }
     parameters.SetString("id", id);
   }
   web_ui()->CallJavascriptFunctionUnsafe("onComponentEvent", parameters);
 }