Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2814043003: Update Crashpad to 1f28a123a4c9449e3d7ddad4ff00dacd366d5216 (Closed)

Created:
3 years, 8 months ago by Sigurður Ásgeirsson
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, kalyank, jam, darin-cc_chromium.org, mac-reviews_chromium.org, chromium-apps-reviews_chromium.org, scottmg, manzagop (departed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to 1f28a123a4c9449e3d7ddad4ff00dacd366d5216 46f403377367 posix: Add ScopedDIR for managing open directories ab9c03f8827b win: Promote WinMultiProcessWithTempDir to test/win for reuse 9c6d190b9570 linux: Add ScopedPtraceAttach to manage ptrace attachments fd9f952393ea Fix crashpad_util_test build with GCC after 4b450c813795 e142aa87d663 linux: Fix crashpad_util_test ScopedPtraceAttach.* with the Yama LSM a5d81370beda linux: Use pread64() instead of pread() in ProcessMemory 30385d4e4772 handler: Add user extensibility stream call-out 79425e4d9737 win: Free an old buffer before attempting to allocate a resized one 1f28a123a4c9 designdoc: Add description of user data sources BUG=crashpad:167, crashpad:30 Review-Url: https://codereview.chromium.org/2814043003 Cr-Commit-Position: refs/heads/master@{#464059} Committed: https://chromium.googlesource.com/chromium/src/+/bcba287825394261983a99443cb1be450de1083c

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add missing GN config to fix compile/link. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1345 lines, -360 lines) Patch
M build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/crash/content/app/run_as_crashpad_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/build/run_tests.py View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_win_test.cc View 7 chunks +6 lines, -188 lines 0 comments Download
A + third_party/crashpad/crashpad/compat/android/linux/prctl.h View 1 chunk +8 lines, -13 lines 0 comments Download
M third_party/crashpad/crashpad/crashpad.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/doc/overview_design.md View 2 chunks +14 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/handler/crashpad_handler_test.cc View 1 chunk +132 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/handler/crashpad_handler_test_extended_handler.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler_main.h View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/handler/handler_main.cc View 2 chunks +7 lines, -3 lines 0 comments Download
A third_party/crashpad/crashpad/handler/handler_test.gyp View 1 chunk +64 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/handler/mac/crash_report_exception_handler.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/handler/main.cc View 1 chunk +10 lines, -2 lines 0 comments Download
A third_party/crashpad/crashpad/handler/user_stream_data_source.h View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/handler/user_stream_data_source.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/handler/win/crash_report_exception_handler.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_file_writer_test.cc View 3 chunks +36 lines, -4 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_test.gyp View 3 chunks +30 lines, -13 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_user_extension_stream_data_source.h View 1 chunk +40 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_user_extension_stream_data_source.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_user_stream_writer.h View 3 chunks +6 lines, -9 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_user_stream_writer.cc View 2 chunks +24 lines, -16 lines 0 comments Download
M third_party/crashpad/crashpad/minidump/minidump_user_stream_writer_test.cc View 3 chunks +9 lines, -5 lines 0 comments Download
A third_party/crashpad/crashpad/minidump/test/minidump_user_extension_stream_util.h View 1 chunk +53 lines, -0 lines 0 comments Download
A + third_party/crashpad/crashpad/minidump/test/minidump_user_extension_stream_util.cc View 1 chunk +22 lines, -9 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/test/test.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/test/win/win_multiprocess_with_temp_dir.h View 1 chunk +80 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/test/win/win_multiprocess_with_temp_dir.cc View 1 chunk +188 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/linux/process_memory.cc View 2 chunks +5 lines, -4 lines 0 comments Download
A third_party/crashpad/crashpad/util/linux/scoped_ptrace_attach.h View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/linux/scoped_ptrace_attach.cc View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/linux/scoped_ptrace_attach_test.cc View 1 chunk +204 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/posix/close_multiple.cc View 3 chunks +1 line, -13 lines 0 comments Download
M third_party/crashpad/crashpad/util/posix/process_info_linux.cc View 4 chunks +3 lines, -25 lines 0 comments Download
A + third_party/crashpad/crashpad/util/posix/scoped_dir.h View 1 chunk +18 lines, -10 lines 0 comments Download
A + third_party/crashpad/crashpad/util/posix/scoped_dir.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/crashpad/crashpad/util/util.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/util_test.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Sigurður Ásgeirsson
PTAL - I'm not sure whether this roll addresses other bugs, but it should unblock ...
3 years, 8 months ago (2017-04-12 14:16:37 UTC) #5
Mark Mentovai
LGTM once these are fixed and the trybots are happy. https://codereview.chromium.org/2814043003/diff/1/components/crash/content/app/run_as_crashpad_handler_win.cc File components/crash/content/app/run_as_crashpad_handler_win.cc (right): https://codereview.chromium.org/2814043003/diff/1/components/crash/content/app/run_as_crashpad_handler_win.cc#newcode1 ...
3 years, 8 months ago (2017-04-12 15:03:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2814043003/20001
3 years, 8 months ago (2017-04-12 16:59:46 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 17:13:15 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bcba287825394261983a99443cb1...

Powered by Google App Engine
This is Rietveld 408576698