Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/crashpad/crashpad/util/linux/process_memory.cc

Issue 2814043003: Update Crashpad to 1f28a123a4c9449e3d7ddad4ff00dacd366d5216 (Closed)
Patch Set: Add missing GN config to fix compile/link. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/linux/process_memory.cc
diff --git a/third_party/crashpad/crashpad/util/linux/process_memory.cc b/third_party/crashpad/crashpad/util/linux/process_memory.cc
index 72b05bfdd2aa80f4f25c489ea3b0e8c1c6bfad3d..8f3290acb233f256632a29b9480ba660866e7465 100644
--- a/third_party/crashpad/crashpad/util/linux/process_memory.cc
+++ b/third_party/crashpad/crashpad/util/linux/process_memory.cc
@@ -50,9 +50,9 @@ bool ProcessMemory::Read(LinuxVMAddress address,
char* buffer_c = static_cast<char*>(buffer);
while (size > 0) {
ssize_t bytes_read =
- HANDLE_EINTR(pread(mem_fd_.get(), buffer_c, size, address));
+ HANDLE_EINTR(pread64(mem_fd_.get(), buffer_c, size, address));
if (bytes_read < 0) {
- PLOG(ERROR) << "pread";
+ PLOG(ERROR) << "pread64";
return false;
}
if (bytes_read == 0) {
@@ -95,9 +95,10 @@ bool ProcessMemory::ReadCStringInternal(LinuxVMAddress address,
read_size = sizeof(buffer);
}
ssize_t bytes_read;
- bytes_read = HANDLE_EINTR(pread(mem_fd_.get(), buffer, read_size, address));
+ bytes_read =
+ HANDLE_EINTR(pread64(mem_fd_.get(), buffer, read_size, address));
if (bytes_read < 0) {
- PLOG(ERROR) << "pread";
+ PLOG(ERROR) << "pread64";
return false;
}
if (bytes_read == 0) {

Powered by Google App Engine
This is Rietveld 408576698