Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc

Issue 2814043003: Update Crashpad to 1f28a123a4c9449e3d7ddad4ff00dacd366d5216 (Closed)
Patch Set: Add missing GN config to fix compile/link. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc
diff --git a/third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc b/third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc
index cb09732291281446c27d98fda091a21a193e1b17..9ad801f7f0334f6dea8baf15abf3968392ed8b4a 100644
--- a/third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc
+++ b/third_party/crashpad/crashpad/test/scoped_temp_dir_test.cc
@@ -38,8 +38,10 @@ void CreateFile(const base::FilePath& path) {
#if defined(OS_POSIX)
int fd = HANDLE_EINTR(creat(path.value().c_str(), 0644));
ASSERT_GE(fd, 0) << ErrnoMessage("creat") << " " << path.value();
- ASSERT_EQ(IGNORE_EINTR(close(fd)), 0) << ErrnoMessage("close") << " "
- << path.value();
+
+ // gcc refuses to compile ASSERT_EQ(IGNORE_EINTR(close(fd)), 0).
+ int close_rv = IGNORE_EINTR(close(fd));
+ ASSERT_EQ(close_rv, 0) << ErrnoMessage("close") << " " << path.value();
#elif defined(OS_WIN)
int fd = _wcreat(path.value().c_str(), _S_IREAD | _S_IWRITE);
ASSERT_GE(fd, 0) << ErrnoMessage("_wcreat") << " " << path.value();
« no previous file with comments | « third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc ('k') | third_party/crashpad/crashpad/test/test.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698