Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2813353003: Move some File API backend unit tests next to the files that they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some File API backend unit tests next to the files that they cover. BUG=653751 Review-Url: https://codereview.chromium.org/2813353003 Cr-Commit-Position: refs/heads/master@{#464687} Committed: https://chromium.googlesource.com/chromium/src/+/2383850584645fc89acd0332c11a592e0b0fd21c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3820 lines) Patch
D content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D content/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +0 lines, -456 lines 0 comments Download
D content/browser/fileapi/file_system_file_stream_reader_unittest.cc View 1 chunk +0 lines, -274 lines 0 comments Download
D content/browser/fileapi/file_system_quota_client_unittest.cc View 1 chunk +0 lines, -572 lines 0 comments Download
D content/browser/fileapi/file_system_url_request_job_unittest.cc View 1 chunk +0 lines, -484 lines 0 comments Download
D content/browser/fileapi/file_writer_delegate_unittest.cc View 1 chunk +0 lines, -505 lines 0 comments Download
D content/browser/fileapi/local_file_util_unittest.cc View 1 chunk +0 lines, -382 lines 0 comments Download
D content/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 1 chunk +0 lines, -288 lines 0 comments Download
D content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D content/browser/fileapi/sandbox_file_system_backend_unittest.cc View 1 chunk +0 lines, -311 lines 0 comments Download
D content/browser/fileapi/transient_file_util_unittest.cc View 1 chunk +0 lines, -123 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A + storage/browser/fileapi/copy_or_move_file_validator_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_file_stream_reader_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_quota_client_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_system_url_request_job_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/file_writer_delegate_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/local_file_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/sandbox_file_system_backend_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/fileapi/transient_file_util_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
pwnall
PTAL? Te diff count looks scary, but this CL is only moves and BUILD.gn changes.
3 years, 8 months ago (2017-04-13 23:03:28 UTC) #4
kinuko
lgtm
3 years, 8 months ago (2017-04-14 05:44:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813353003/1
3 years, 8 months ago (2017-04-14 05:44:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 06:10:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2383850584645fc89acd0332c11a...

Powered by Google App Engine
This is Rietveld 408576698