Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/fileapi/file_writer_delegate_unittest.cc

Issue 2813353003: Move some File API backend unit tests next to the files that they cover. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/fileapi/file_system_url_request_job_unittest.cc ('k') | content/browser/fileapi/local_file_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/fileapi/file_writer_delegate_unittest.cc
diff --git a/content/browser/fileapi/file_writer_delegate_unittest.cc b/content/browser/fileapi/file_writer_delegate_unittest.cc
deleted file mode 100644
index 3a879933622ec885637723ade867830f69085f34..0000000000000000000000000000000000000000
--- a/content/browser/fileapi/file_writer_delegate_unittest.cc
+++ /dev/null
@@ -1,505 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <stdint.h>
-#include <limits>
-#include <string>
-#include <utility>
-#include <vector>
-
-#include "base/bind.h"
-#include "base/bind_helpers.h"
-#include "base/files/scoped_temp_dir.h"
-#include "base/location.h"
-#include "base/macros.h"
-#include "base/memory/weak_ptr.h"
-#include "base/run_loop.h"
-#include "base/single_thread_task_runner.h"
-#include "base/threading/thread_task_runner_handle.h"
-#include "net/base/io_buffer.h"
-#include "net/base/request_priority.h"
-#include "net/url_request/url_request.h"
-#include "net/url_request/url_request_context.h"
-#include "net/url_request/url_request_job.h"
-#include "net/url_request/url_request_job_factory.h"
-#include "net/url_request/url_request_status.h"
-#include "storage/browser/fileapi/file_system_context.h"
-#include "storage/browser/fileapi/file_system_quota_util.h"
-#include "storage/browser/fileapi/file_writer_delegate.h"
-#include "storage/browser/fileapi/sandbox_file_stream_writer.h"
-#include "storage/browser/test/async_file_test_helper.h"
-#include "storage/browser/test/test_file_system_context.h"
-#include "storage/common/fileapi/file_system_mount_option.h"
-#include "testing/platform_test.h"
-#include "url/gurl.h"
-
-using content::AsyncFileTestHelper;
-using storage::FileSystemURL;
-using storage::FileWriterDelegate;
-
-namespace content {
-
-namespace {
-
-const GURL kOrigin("http://example.com");
-const storage::FileSystemType kFileSystemType = storage::kFileSystemTypeTest;
-
-const char kData[] = "The quick brown fox jumps over the lazy dog.\n";
-const int kDataSize = arraysize(kData) - 1;
-
-class Result {
- public:
- Result()
- : status_(base::File::FILE_OK),
- bytes_written_(0),
- write_status_(FileWriterDelegate::SUCCESS_IO_PENDING) {}
-
- base::File::Error status() const { return status_; }
- int64_t bytes_written() const { return bytes_written_; }
- FileWriterDelegate::WriteProgressStatus write_status() const {
- return write_status_;
- }
-
- void DidWrite(base::File::Error status,
- int64_t bytes,
- FileWriterDelegate::WriteProgressStatus write_status) {
- write_status_ = write_status;
- if (status == base::File::FILE_OK) {
- bytes_written_ += bytes;
- if (write_status_ != FileWriterDelegate::SUCCESS_IO_PENDING)
- base::MessageLoop::current()->QuitWhenIdle();
- } else {
- EXPECT_EQ(base::File::FILE_OK, status_);
- status_ = status;
- base::MessageLoop::current()->QuitWhenIdle();
- }
- }
-
- private:
- // For post-operation status.
- base::File::Error status_;
- int64_t bytes_written_;
- FileWriterDelegate::WriteProgressStatus write_status_;
-};
-
-class BlobURLRequestJobFactory;
-
-} // namespace (anonymous)
-
-class FileWriterDelegateTest : public PlatformTest {
- public:
- FileWriterDelegateTest() {}
-
- protected:
- void SetUp() override;
- void TearDown() override;
-
- int64_t usage() {
- return file_system_context_->GetQuotaUtil(kFileSystemType)
- ->GetOriginUsageOnFileTaskRunner(
- file_system_context_.get(), kOrigin, kFileSystemType);
- }
-
- int64_t GetFileSizeOnDisk(const char* test_file_path) {
- // There might be in-flight flush/write.
- base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
- base::Bind(&base::DoNothing));
- base::RunLoop().RunUntilIdle();
-
- FileSystemURL url = GetFileSystemURL(test_file_path);
- base::File::Info file_info;
- EXPECT_EQ(base::File::FILE_OK,
- AsyncFileTestHelper::GetMetadata(
- file_system_context_.get(), url, &file_info));
- return file_info.size;
- }
-
- FileSystemURL GetFileSystemURL(const char* file_name) const {
- return file_system_context_->CreateCrackedFileSystemURL(
- kOrigin, kFileSystemType, base::FilePath().FromUTF8Unsafe(file_name));
- }
-
- FileWriterDelegate* CreateWriterDelegate(const char* test_file_path,
- int64_t offset,
- int64_t allowed_growth) {
- storage::SandboxFileStreamWriter* writer =
- new storage::SandboxFileStreamWriter(
- file_system_context_.get(),
- GetFileSystemURL(test_file_path),
- offset,
- *file_system_context_->GetUpdateObservers(kFileSystemType));
- writer->set_default_quota(allowed_growth);
- return new FileWriterDelegate(
- std::unique_ptr<storage::FileStreamWriter>(writer),
- storage::FlushPolicy::FLUSH_ON_COMPLETION);
- }
-
- FileWriterDelegate::DelegateWriteCallback GetWriteCallback(Result* result) {
- return base::Bind(&Result::DidWrite, base::Unretained(result));
- }
-
- // Creates and sets up a FileWriterDelegate for writing the given |blob_url|,
- // and creates a new FileWriterDelegate for the file.
- void PrepareForWrite(const char* test_file_path,
- const GURL& blob_url,
- int64_t offset,
- int64_t allowed_growth) {
- file_writer_delegate_.reset(
- CreateWriterDelegate(test_file_path, offset, allowed_growth));
- request_ = empty_context_.CreateRequest(
- blob_url, net::DEFAULT_PRIORITY, file_writer_delegate_.get());
- }
-
- // This should be alive until the very end of this instance.
- base::MessageLoopForIO loop_;
-
- scoped_refptr<storage::FileSystemContext> file_system_context_;
-
- net::URLRequestContext empty_context_;
- std::unique_ptr<FileWriterDelegate> file_writer_delegate_;
- std::unique_ptr<net::URLRequest> request_;
- std::unique_ptr<BlobURLRequestJobFactory> job_factory_;
-
- base::ScopedTempDir dir_;
-
- static const char* content_;
-};
-
-const char* FileWriterDelegateTest::content_ = NULL;
-
-namespace {
-
-static std::string g_content;
-
-class FileWriterDelegateTestJob : public net::URLRequestJob {
- public:
- FileWriterDelegateTestJob(net::URLRequest* request,
- net::NetworkDelegate* network_delegate,
- const std::string& content)
- : net::URLRequestJob(request, network_delegate),
- content_(content),
- remaining_bytes_(content.length()),
- cursor_(0),
- weak_factory_(this) {}
-
- void Start() override {
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(&FileWriterDelegateTestJob::NotifyHeadersComplete,
- weak_factory_.GetWeakPtr()));
- }
-
- int ReadRawData(net::IOBuffer* buf, int buf_size) override {
- if (remaining_bytes_ < buf_size)
- buf_size = remaining_bytes_;
-
- for (int i = 0; i < buf_size; ++i)
- buf->data()[i] = content_[cursor_++];
- remaining_bytes_ -= buf_size;
-
- return buf_size;
- }
-
- int GetResponseCode() const override { return 200; }
-
- protected:
- ~FileWriterDelegateTestJob() override {}
-
- private:
- std::string content_;
- int remaining_bytes_;
- int cursor_;
-
- base::WeakPtrFactory<FileWriterDelegateTestJob> weak_factory_;
-};
-
-class BlobURLRequestJobFactory : public net::URLRequestJobFactory {
- public:
- explicit BlobURLRequestJobFactory(const char** content_data)
- : content_data_(content_data) {
- }
-
- net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
- const std::string& scheme,
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const override {
- return new FileWriterDelegateTestJob(
- request, network_delegate, *content_data_);
- }
-
- net::URLRequestJob* MaybeInterceptRedirect(
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate,
- const GURL& location) const override {
- return nullptr;
- }
-
- net::URLRequestJob* MaybeInterceptResponse(
- net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const override {
- return nullptr;
- }
-
- bool IsHandledProtocol(const std::string& scheme) const override {
- return scheme == "blob";
- }
-
- bool IsSafeRedirectTarget(const GURL& location) const override {
- return true;
- }
-
- private:
- const char** content_data_;
-
- DISALLOW_COPY_AND_ASSIGN(BlobURLRequestJobFactory);
-};
-
-} // namespace (anonymous)
-
-void FileWriterDelegateTest::SetUp() {
- ASSERT_TRUE(dir_.CreateUniqueTempDir());
-
- file_system_context_ =
- CreateFileSystemContextForTesting(NULL, dir_.GetPath());
- ASSERT_EQ(base::File::FILE_OK,
- AsyncFileTestHelper::CreateFile(file_system_context_.get(),
- GetFileSystemURL("test")));
- job_factory_.reset(new BlobURLRequestJobFactory(&content_));
- empty_context_.set_job_factory(job_factory_.get());
-}
-
-void FileWriterDelegateTest::TearDown() {
- file_system_context_ = NULL;
- base::RunLoop().RunUntilIdle();
-}
-
-TEST_F(FileWriterDelegateTest, WriteSuccessWithoutQuotaLimit) {
- const GURL kBlobURL("blob:nolimit");
- content_ = kData;
-
- PrepareForWrite("test", kBlobURL, 0, std::numeric_limits<int64_t>::max());
-
- Result result;
- ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
- base::RunLoop().Run();
-
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- file_writer_delegate_.reset();
-
- ASSERT_EQ(kDataSize, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
- EXPECT_EQ(kDataSize, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
-}
-
-TEST_F(FileWriterDelegateTest, WriteSuccessWithJustQuota) {
- const GURL kBlobURL("blob:just");
- content_ = kData;
- const int64_t kAllowedGrowth = kDataSize;
- PrepareForWrite("test", kBlobURL, 0, kAllowedGrowth);
-
- Result result;
- ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
- base::RunLoop().Run();
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- file_writer_delegate_.reset();
-
- ASSERT_EQ(kAllowedGrowth, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
-
- EXPECT_EQ(kAllowedGrowth, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
-}
-
-TEST_F(FileWriterDelegateTest, DISABLED_WriteFailureByQuota) {
- const GURL kBlobURL("blob:failure");
- content_ = kData;
- const int64_t kAllowedGrowth = kDataSize - 1;
- PrepareForWrite("test", kBlobURL, 0, kAllowedGrowth);
-
- Result result;
- ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
- base::RunLoop().Run();
- ASSERT_EQ(FileWriterDelegate::ERROR_WRITE_STARTED, result.write_status());
- file_writer_delegate_.reset();
-
- ASSERT_EQ(kAllowedGrowth, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
-
- EXPECT_EQ(kAllowedGrowth, result.bytes_written());
- EXPECT_EQ(base::File::FILE_ERROR_NO_SPACE, result.status());
- ASSERT_EQ(FileWriterDelegate::ERROR_WRITE_STARTED, result.write_status());
-}
-
-TEST_F(FileWriterDelegateTest, WriteZeroBytesSuccessfullyWithZeroQuota) {
- const GURL kBlobURL("blob:zero");
- content_ = "";
- int64_t kAllowedGrowth = 0;
- PrepareForWrite("test", kBlobURL, 0, kAllowedGrowth);
-
- Result result;
- ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
- base::RunLoop().Run();
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- file_writer_delegate_.reset();
-
- ASSERT_EQ(kAllowedGrowth, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
-
- EXPECT_EQ(kAllowedGrowth, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
-}
-
-TEST_F(FileWriterDelegateTest, WriteSuccessWithoutQuotaLimitConcurrent) {
- std::unique_ptr<FileWriterDelegate> file_writer_delegate2;
- std::unique_ptr<net::URLRequest> request2;
-
- ASSERT_EQ(base::File::FILE_OK,
- AsyncFileTestHelper::CreateFile(file_system_context_.get(),
- GetFileSystemURL("test2")));
-
- const GURL kBlobURL("blob:nolimitconcurrent");
- const GURL kBlobURL2("blob:nolimitconcurrent2");
- content_ = kData;
-
- PrepareForWrite("test", kBlobURL, 0, std::numeric_limits<int64_t>::max());
-
- // Credate another FileWriterDelegate for concurrent write.
- file_writer_delegate2.reset(
- CreateWriterDelegate("test2", 0, std::numeric_limits<int64_t>::max()));
- request2 = empty_context_.CreateRequest(
- kBlobURL2, net::DEFAULT_PRIORITY, file_writer_delegate2.get());
-
- Result result, result2;
- ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(std::move(request_), GetWriteCallback(&result));
- file_writer_delegate2->Start(std::move(request2), GetWriteCallback(&result2));
- base::RunLoop().Run();
- if (result.write_status() == FileWriterDelegate::SUCCESS_IO_PENDING ||
- result2.write_status() == FileWriterDelegate::SUCCESS_IO_PENDING)
- base::RunLoop().Run();
-
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result2.write_status());
- file_writer_delegate_.reset();
- file_writer_delegate2.reset();
-
- ASSERT_EQ(kDataSize * 2, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test") + GetFileSizeOnDisk("test2"), usage());
-
- EXPECT_EQ(kDataSize, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
- EXPECT_EQ(kDataSize, result2.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result2.status());
-}
-
-TEST_F(FileWriterDelegateTest, WritesWithQuotaAndOffset) {
- const GURL kBlobURL("blob:failure-with-updated-quota");
- content_ = kData;
-
- // Writing kDataSize (=45) bytes data while allowed_growth is 100.
- int64_t offset = 0;
- int64_t allowed_growth = 100;
- ASSERT_LT(kDataSize, allowed_growth);
- PrepareForWrite("test", kBlobURL, offset, allowed_growth);
-
- {
- Result result;
- ASSERT_EQ(0, usage());
- file_writer_delegate_->Start(std::move(request_),
- GetWriteCallback(&result));
- base::RunLoop().Run();
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- file_writer_delegate_.reset();
-
- ASSERT_EQ(kDataSize, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
- EXPECT_EQ(kDataSize, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
- }
-
- // Trying to overwrite kDataSize bytes data while allowed_growth is 20.
- offset = 0;
- allowed_growth = 20;
- PrepareForWrite("test", kBlobURL, offset, allowed_growth);
-
- {
- Result result;
- file_writer_delegate_->Start(std::move(request_),
- GetWriteCallback(&result));
- base::RunLoop().Run();
- EXPECT_EQ(kDataSize, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
- EXPECT_EQ(kDataSize, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- }
-
- // Trying to write kDataSize bytes data from offset 25 while
- // allowed_growth is 55.
- offset = 25;
- allowed_growth = 55;
- PrepareForWrite("test", kBlobURL, offset, allowed_growth);
-
- {
- Result result;
- file_writer_delegate_->Start(std::move(request_),
- GetWriteCallback(&result));
- base::RunLoop().Run();
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- file_writer_delegate_.reset();
-
- EXPECT_EQ(offset + kDataSize, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
- EXPECT_EQ(kDataSize, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
- }
-
- // Trying to overwrite 45 bytes data while allowed_growth is -20.
- offset = 0;
- allowed_growth = -20;
- PrepareForWrite("test", kBlobURL, offset, allowed_growth);
- int64_t pre_write_usage = GetFileSizeOnDisk("test");
-
- {
- Result result;
- file_writer_delegate_->Start(std::move(request_),
- GetWriteCallback(&result));
- base::RunLoop().Run();
- ASSERT_EQ(FileWriterDelegate::SUCCESS_COMPLETED, result.write_status());
- file_writer_delegate_.reset();
-
- EXPECT_EQ(pre_write_usage, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
- EXPECT_EQ(kDataSize, result.bytes_written());
- EXPECT_EQ(base::File::FILE_OK, result.status());
- }
-
- // Trying to overwrite 45 bytes data with offset pre_write_usage - 20,
- // while allowed_growth is 10.
- const int kOverlap = 20;
- offset = pre_write_usage - kOverlap;
- allowed_growth = 10;
- PrepareForWrite("test", kBlobURL, offset, allowed_growth);
-
- {
- Result result;
- file_writer_delegate_->Start(std::move(request_),
- GetWriteCallback(&result));
- base::RunLoop().Run();
- ASSERT_EQ(FileWriterDelegate::ERROR_WRITE_STARTED, result.write_status());
- file_writer_delegate_.reset();
-
- EXPECT_EQ(pre_write_usage + allowed_growth, usage());
- EXPECT_EQ(GetFileSizeOnDisk("test"), usage());
- EXPECT_EQ(kOverlap + allowed_growth, result.bytes_written());
- EXPECT_EQ(base::File::FILE_ERROR_NO_SPACE, result.status());
- }
-}
-
-} // namespace content
« no previous file with comments | « content/browser/fileapi/file_system_url_request_job_unittest.cc ('k') | content/browser/fileapi/local_file_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698