Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: content/browser/fileapi/file_system_url_request_job_unittest.cc

Issue 2813353003: Move some File API backend unit tests next to the files that they cover. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <stddef.h>
6 #include <string>
7 #include <utility>
8
9 #include "base/bind.h"
10 #include "base/files/file_path.h"
11 #include "base/files/file_util.h"
12 #include "base/files/scoped_temp_dir.h"
13 #include "base/format_macros.h"
14 #include "base/location.h"
15 #include "base/macros.h"
16 #include "base/memory/ptr_util.h"
17 #include "base/memory/weak_ptr.h"
18 #include "base/rand_util.h"
19 #include "base/run_loop.h"
20 #include "base/single_thread_task_runner.h"
21 #include "base/strings/string_piece.h"
22 #include "base/strings/stringprintf.h"
23 #include "base/strings/utf_string_conversions.h"
24 #include "base/threading/thread_task_runner_handle.h"
25 #include "net/base/load_flags.h"
26 #include "net/base/mime_util.h"
27 #include "net/base/net_errors.h"
28 #include "net/base/request_priority.h"
29 #include "net/http/http_byte_range.h"
30 #include "net/http/http_request_headers.h"
31 #include "net/url_request/url_request.h"
32 #include "net/url_request/url_request_context.h"
33 #include "net/url_request/url_request_test_util.h"
34 #include "storage/browser/fileapi/external_mount_points.h"
35 #include "storage/browser/fileapi/file_system_context.h"
36 #include "storage/browser/fileapi/file_system_file_util.h"
37 #include "storage/browser/fileapi/file_system_url_request_job.h"
38 #include "storage/browser/test/async_file_test_helper.h"
39 #include "storage/browser/test/test_file_system_backend.h"
40 #include "storage/browser/test/test_file_system_context.h"
41 #include "testing/gtest/include/gtest/gtest.h"
42
43 using content::AsyncFileTestHelper;
44 using storage::FileSystemContext;
45 using storage::FileSystemURL;
46 using storage::FileSystemURLRequestJob;
47
48 namespace content {
49 namespace {
50
51 // We always use the TEMPORARY FileSystem in this test.
52 const char kFileSystemURLPrefix[] = "filesystem:http://remote/temporary/";
53 const char kTestFileData[] = "0123456789";
54
55 void FillBuffer(char* buffer, size_t len) {
56 base::RandBytes(buffer, len);
57 }
58
59 const char kValidExternalMountPoint[] = "mnt_name";
60
61 // An auto mounter that will try to mount anything for |storage_domain| =
62 // "automount", but will only succeed for the mount point "mnt_name".
63 bool TestAutoMountForURLRequest(
64 const net::URLRequest* /*url_request*/,
65 const storage::FileSystemURL& filesystem_url,
66 const std::string& storage_domain,
67 const base::Callback<void(base::File::Error result)>& callback) {
68 if (storage_domain != "automount")
69 return false;
70 std::vector<base::FilePath::StringType> components;
71 filesystem_url.path().GetComponents(&components);
72 std::string mount_point = base::FilePath(components[0]).AsUTF8Unsafe();
73
74 if (mount_point == kValidExternalMountPoint) {
75 storage::ExternalMountPoints::GetSystemInstance()->RegisterFileSystem(
76 kValidExternalMountPoint,
77 storage::kFileSystemTypeTest,
78 storage::FileSystemMountOption(),
79 base::FilePath());
80 callback.Run(base::File::FILE_OK);
81 } else {
82 callback.Run(base::File::FILE_ERROR_NOT_FOUND);
83 }
84 return true;
85 }
86
87 class FileSystemURLRequestJobFactory : public net::URLRequestJobFactory {
88 public:
89 FileSystemURLRequestJobFactory(const std::string& storage_domain,
90 FileSystemContext* context)
91 : storage_domain_(storage_domain), file_system_context_(context) {
92 }
93
94 net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
95 const std::string& scheme,
96 net::URLRequest* request,
97 net::NetworkDelegate* network_delegate) const override {
98 return new storage::FileSystemURLRequestJob(
99 request, network_delegate, storage_domain_, file_system_context_);
100 }
101
102 net::URLRequestJob* MaybeInterceptRedirect(
103 net::URLRequest* request,
104 net::NetworkDelegate* network_delegate,
105 const GURL& location) const override {
106 return nullptr;
107 }
108
109 net::URLRequestJob* MaybeInterceptResponse(
110 net::URLRequest* request,
111 net::NetworkDelegate* network_delegate) const override {
112 return nullptr;
113 }
114
115 bool IsHandledProtocol(const std::string& scheme) const override {
116 return true;
117 }
118
119 bool IsSafeRedirectTarget(const GURL& location) const override {
120 return false;
121 }
122
123 private:
124 std::string storage_domain_;
125 FileSystemContext* file_system_context_;
126 };
127
128 } // namespace
129
130 class FileSystemURLRequestJobTest : public testing::Test {
131 protected:
132 FileSystemURLRequestJobTest() : weak_factory_(this) {
133 }
134
135 void SetUp() override {
136 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
137
138 // We use the main thread so that we can get the root path synchronously.
139 // TODO(adamk): Run this on the FILE thread we've created as well.
140 file_system_context_ =
141 CreateFileSystemContextForTesting(NULL, temp_dir_.GetPath());
142
143 file_system_context_->OpenFileSystem(
144 GURL("http://remote/"),
145 storage::kFileSystemTypeTemporary,
146 storage::OPEN_FILE_SYSTEM_CREATE_IF_NONEXISTENT,
147 base::Bind(&FileSystemURLRequestJobTest::OnOpenFileSystem,
148 weak_factory_.GetWeakPtr()));
149 base::RunLoop().RunUntilIdle();
150 }
151
152 void TearDown() override {
153 // FileReader posts a task to close the file in destructor.
154 base::RunLoop().RunUntilIdle();
155 }
156
157 void SetUpAutoMountContext() {
158 base::FilePath mnt_point =
159 temp_dir_.GetPath().AppendASCII("auto_mount_dir");
160 ASSERT_TRUE(base::CreateDirectory(mnt_point));
161
162 std::vector<std::unique_ptr<storage::FileSystemBackend>>
163 additional_providers;
164 additional_providers.push_back(base::MakeUnique<TestFileSystemBackend>(
165 base::ThreadTaskRunnerHandle::Get().get(), mnt_point));
166
167 std::vector<storage::URLRequestAutoMountHandler> handlers;
168 handlers.push_back(base::Bind(&TestAutoMountForURLRequest));
169
170 file_system_context_ = CreateFileSystemContextWithAutoMountersForTesting(
171 NULL, std::move(additional_providers), handlers, temp_dir_.GetPath());
172
173 ASSERT_EQ(static_cast<int>(sizeof(kTestFileData)) - 1,
174 base::WriteFile(mnt_point.AppendASCII("foo"), kTestFileData,
175 sizeof(kTestFileData) - 1));
176 }
177
178 void OnOpenFileSystem(const GURL& root_url,
179 const std::string& name,
180 base::File::Error result) {
181 ASSERT_EQ(base::File::FILE_OK, result);
182 }
183
184 void TestRequestHelper(const GURL& url,
185 const net::HttpRequestHeaders* headers,
186 bool run_to_completion,
187 FileSystemContext* file_system_context) {
188 delegate_.reset(new net::TestDelegate());
189 // Make delegate_ exit the MessageLoop when the request is done.
190 delegate_->set_quit_on_complete(true);
191 delegate_->set_quit_on_redirect(true);
192
193 job_factory_.reset(new FileSystemURLRequestJobFactory(
194 url.GetOrigin().host(), file_system_context));
195 empty_context_.set_job_factory(job_factory_.get());
196
197 request_ = empty_context_.CreateRequest(
198 url, net::DEFAULT_PRIORITY, delegate_.get());
199 if (headers)
200 request_->SetExtraRequestHeaders(*headers);
201
202 request_->Start();
203 ASSERT_TRUE(request_->is_pending()); // verify that we're starting async
204 if (run_to_completion)
205 base::RunLoop().Run();
206 }
207
208 void TestRequest(const GURL& url) {
209 TestRequestHelper(url, NULL, true, file_system_context_.get());
210 }
211
212 void TestRequestWithContext(const GURL& url,
213 FileSystemContext* file_system_context) {
214 TestRequestHelper(url, NULL, true, file_system_context);
215 }
216
217 void TestRequestWithHeaders(const GURL& url,
218 const net::HttpRequestHeaders* headers) {
219 TestRequestHelper(url, headers, true, file_system_context_.get());
220 }
221
222 void TestRequestNoRun(const GURL& url) {
223 TestRequestHelper(url, NULL, false, file_system_context_.get());
224 }
225
226 void CreateDirectory(const base::StringPiece& dir_name) {
227 FileSystemURL url = file_system_context_->CreateCrackedFileSystemURL(
228 GURL("http://remote"),
229 storage::kFileSystemTypeTemporary,
230 base::FilePath().AppendASCII(dir_name));
231 ASSERT_EQ(
232 base::File::FILE_OK,
233 AsyncFileTestHelper::CreateDirectory(file_system_context_.get(), url));
234 }
235
236 void WriteFile(const base::StringPiece& file_name,
237 const char* buf, int buf_size) {
238 FileSystemURL url = file_system_context_->CreateCrackedFileSystemURL(
239 GURL("http://remote"),
240 storage::kFileSystemTypeTemporary,
241 base::FilePath().AppendASCII(file_name));
242 ASSERT_EQ(base::File::FILE_OK,
243 AsyncFileTestHelper::CreateFileWithData(
244 file_system_context_.get(), url, buf, buf_size));
245 }
246
247 GURL CreateFileSystemURL(const std::string& path) {
248 return GURL(kFileSystemURLPrefix + path);
249 }
250
251 // Temp directory is at the top because it must be deleted last.
252 base::ScopedTempDir temp_dir_;
253
254 // The message loop must be deleted second to last.
255 base::MessageLoopForIO message_loop_;
256
257 scoped_refptr<storage::FileSystemContext> file_system_context_;
258
259 net::URLRequestContext empty_context_;
260 std::unique_ptr<FileSystemURLRequestJobFactory> job_factory_;
261
262 // NOTE: order matters, request must die before delegate
263 std::unique_ptr<net::TestDelegate> delegate_;
264 std::unique_ptr<net::URLRequest> request_;
265
266 base::WeakPtrFactory<FileSystemURLRequestJobTest> weak_factory_;
267 };
268
269 namespace {
270
271 TEST_F(FileSystemURLRequestJobTest, FileTest) {
272 WriteFile("file1.dat", kTestFileData, arraysize(kTestFileData) - 1);
273 TestRequest(CreateFileSystemURL("file1.dat"));
274
275 ASSERT_FALSE(request_->is_pending());
276 EXPECT_EQ(1, delegate_->response_started_count());
277 EXPECT_FALSE(delegate_->received_data_before_response());
278 EXPECT_EQ(kTestFileData, delegate_->data_received());
279 EXPECT_EQ(200, request_->GetResponseCode());
280 std::string cache_control;
281 request_->GetResponseHeaderByName("cache-control", &cache_control);
282 EXPECT_EQ("no-cache", cache_control);
283 }
284
285 TEST_F(FileSystemURLRequestJobTest, FileTestFullSpecifiedRange) {
286 const size_t buffer_size = 4000;
287 std::unique_ptr<char[]> buffer(new char[buffer_size]);
288 FillBuffer(buffer.get(), buffer_size);
289 WriteFile("bigfile", buffer.get(), buffer_size);
290
291 const size_t first_byte_position = 500;
292 const size_t last_byte_position = buffer_size - first_byte_position;
293 std::string partial_buffer_string(buffer.get() + first_byte_position,
294 buffer.get() + last_byte_position + 1);
295
296 net::HttpRequestHeaders headers;
297 headers.SetHeader(
298 net::HttpRequestHeaders::kRange,
299 net::HttpByteRange::Bounded(
300 first_byte_position, last_byte_position).GetHeaderValue());
301 TestRequestWithHeaders(CreateFileSystemURL("bigfile"), &headers);
302
303 ASSERT_FALSE(request_->is_pending());
304 EXPECT_EQ(1, delegate_->response_started_count());
305 EXPECT_FALSE(delegate_->received_data_before_response());
306 EXPECT_TRUE(partial_buffer_string == delegate_->data_received());
307 }
308
309 TEST_F(FileSystemURLRequestJobTest, FileTestHalfSpecifiedRange) {
310 const size_t buffer_size = 4000;
311 std::unique_ptr<char[]> buffer(new char[buffer_size]);
312 FillBuffer(buffer.get(), buffer_size);
313 WriteFile("bigfile", buffer.get(), buffer_size);
314
315 const size_t first_byte_position = 500;
316 std::string partial_buffer_string(buffer.get() + first_byte_position,
317 buffer.get() + buffer_size);
318
319 net::HttpRequestHeaders headers;
320 headers.SetHeader(
321 net::HttpRequestHeaders::kRange,
322 net::HttpByteRange::RightUnbounded(first_byte_position).GetHeaderValue());
323 TestRequestWithHeaders(CreateFileSystemURL("bigfile"), &headers);
324 ASSERT_FALSE(request_->is_pending());
325 EXPECT_EQ(1, delegate_->response_started_count());
326 EXPECT_FALSE(delegate_->received_data_before_response());
327 // Don't use EXPECT_EQ, it will print out a lot of garbage if check failed.
328 EXPECT_TRUE(partial_buffer_string == delegate_->data_received());
329 }
330
331 TEST_F(FileSystemURLRequestJobTest, FileTestMultipleRangesNotSupported) {
332 WriteFile("file1.dat", kTestFileData, arraysize(kTestFileData) - 1);
333 net::HttpRequestHeaders headers;
334 headers.SetHeader(net::HttpRequestHeaders::kRange,
335 "bytes=0-5,10-200,200-300");
336 TestRequestWithHeaders(CreateFileSystemURL("file1.dat"), &headers);
337 EXPECT_TRUE(delegate_->request_failed());
338 EXPECT_EQ(net::ERR_REQUEST_RANGE_NOT_SATISFIABLE,
339 delegate_->request_status());
340 }
341
342 TEST_F(FileSystemURLRequestJobTest, RangeOutOfBounds) {
343 WriteFile("file1.dat", kTestFileData, arraysize(kTestFileData) - 1);
344 net::HttpRequestHeaders headers;
345 headers.SetHeader(
346 net::HttpRequestHeaders::kRange,
347 net::HttpByteRange::Bounded(500, 1000).GetHeaderValue());
348 TestRequestWithHeaders(CreateFileSystemURL("file1.dat"), &headers);
349
350 ASSERT_FALSE(request_->is_pending());
351 EXPECT_TRUE(delegate_->request_failed());
352 EXPECT_EQ(net::ERR_REQUEST_RANGE_NOT_SATISFIABLE,
353 delegate_->request_status());
354 }
355
356 TEST_F(FileSystemURLRequestJobTest, FileDirRedirect) {
357 CreateDirectory("dir");
358 TestRequest(CreateFileSystemURL("dir"));
359
360 EXPECT_EQ(1, delegate_->received_redirect_count());
361 EXPECT_FALSE(delegate_->request_failed());
362
363 // We've deferred the redirect; now cancel the request to avoid following it.
364 request_->Cancel();
365 base::RunLoop().Run();
366 }
367
368 TEST_F(FileSystemURLRequestJobTest, InvalidURL) {
369 TestRequest(GURL("filesystem:/foo/bar/baz"));
370 ASSERT_FALSE(request_->is_pending());
371 EXPECT_TRUE(delegate_->request_failed());
372 EXPECT_EQ(net::ERR_INVALID_URL, delegate_->request_status());
373 }
374
375 TEST_F(FileSystemURLRequestJobTest, NoSuchRoot) {
376 TestRequest(GURL("filesystem:http://remote/persistent/somefile"));
377 ASSERT_FALSE(request_->is_pending());
378 EXPECT_TRUE(delegate_->request_failed());
379 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, delegate_->request_status());
380 }
381
382 TEST_F(FileSystemURLRequestJobTest, NoSuchFile) {
383 TestRequest(CreateFileSystemURL("somefile"));
384 ASSERT_FALSE(request_->is_pending());
385 EXPECT_TRUE(delegate_->request_failed());
386 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, delegate_->request_status());
387 }
388
389 TEST_F(FileSystemURLRequestJobTest, Cancel) {
390 WriteFile("file1.dat", kTestFileData, arraysize(kTestFileData) - 1);
391 TestRequestNoRun(CreateFileSystemURL("file1.dat"));
392
393 // Run StartAsync() and only StartAsync().
394 base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE,
395 request_.release());
396 base::RunLoop().RunUntilIdle();
397 // If we get here, success! we didn't crash!
398 }
399
400 TEST_F(FileSystemURLRequestJobTest, GetMimeType) {
401 const char kFilename[] = "hoge.html";
402
403 std::string mime_type_direct;
404 base::FilePath::StringType extension =
405 base::FilePath().AppendASCII(kFilename).Extension();
406 if (!extension.empty())
407 extension = extension.substr(1);
408 EXPECT_TRUE(net::GetWellKnownMimeTypeFromExtension(
409 extension, &mime_type_direct));
410
411 TestRequest(CreateFileSystemURL(kFilename));
412
413 std::string mime_type_from_job;
414 request_->GetMimeType(&mime_type_from_job);
415 EXPECT_EQ(mime_type_direct, mime_type_from_job);
416 }
417
418 TEST_F(FileSystemURLRequestJobTest, Incognito) {
419 WriteFile("file", kTestFileData, arraysize(kTestFileData) - 1);
420
421 // Creates a new filesystem context for incognito mode.
422 scoped_refptr<FileSystemContext> file_system_context =
423 CreateIncognitoFileSystemContextForTesting(NULL, temp_dir_.GetPath());
424
425 // The request should return NOT_FOUND error if it's in incognito mode.
426 TestRequestWithContext(CreateFileSystemURL("file"),
427 file_system_context.get());
428 ASSERT_FALSE(request_->is_pending());
429 EXPECT_TRUE(delegate_->request_failed());
430 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, delegate_->request_status());
431
432 // Make sure it returns success with regular (non-incognito) context.
433 TestRequest(CreateFileSystemURL("file"));
434 ASSERT_FALSE(request_->is_pending());
435 EXPECT_EQ(kTestFileData, delegate_->data_received());
436 EXPECT_EQ(200, request_->GetResponseCode());
437 }
438
439 TEST_F(FileSystemURLRequestJobTest, AutoMountFileTest) {
440 SetUpAutoMountContext();
441 TestRequest(GURL("filesystem:http://automount/external/mnt_name/foo"));
442
443 ASSERT_FALSE(request_->is_pending());
444 EXPECT_EQ(1, delegate_->response_started_count());
445 EXPECT_FALSE(delegate_->received_data_before_response());
446 EXPECT_EQ(kTestFileData, delegate_->data_received());
447 EXPECT_EQ(200, request_->GetResponseCode());
448 std::string cache_control;
449 request_->GetResponseHeaderByName("cache-control", &cache_control);
450 EXPECT_EQ("no-cache", cache_control);
451
452 ASSERT_TRUE(
453 storage::ExternalMountPoints::GetSystemInstance()->RevokeFileSystem(
454 kValidExternalMountPoint));
455 }
456
457 TEST_F(FileSystemURLRequestJobTest, AutoMountInvalidRoot) {
458 SetUpAutoMountContext();
459 TestRequest(GURL("filesystem:http://automount/external/invalid/foo"));
460
461 ASSERT_FALSE(request_->is_pending());
462 EXPECT_TRUE(delegate_->request_failed());
463 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, delegate_->request_status());
464
465 ASSERT_FALSE(
466 storage::ExternalMountPoints::GetSystemInstance()->RevokeFileSystem(
467 "invalid"));
468 }
469
470 TEST_F(FileSystemURLRequestJobTest, AutoMountNoHandler) {
471 SetUpAutoMountContext();
472 TestRequest(GURL("filesystem:http://noauto/external/mnt_name/foo"));
473
474 ASSERT_FALSE(request_->is_pending());
475 EXPECT_TRUE(delegate_->request_failed());
476 EXPECT_EQ(net::ERR_FILE_NOT_FOUND, delegate_->request_status());
477
478 ASSERT_FALSE(
479 storage::ExternalMountPoints::GetSystemInstance()->RevokeFileSystem(
480 kValidExternalMountPoint));
481 }
482
483 } // namespace
484 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/fileapi/file_system_quota_client_unittest.cc ('k') | content/browser/fileapi/file_writer_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698