Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 2817133002: Move a couple of quota unit tests next to the files they cover. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move a couple of quota unit tests next to the files they cover. BUG=653751 Review-Url: https://codereview.chromium.org/2817133002 Cr-Commit-Position: refs/heads/master@{#464691} Committed: https://chromium.googlesource.com/chromium/src/+/9b0072b76bafcb7ef0db04a10f118d4329622d2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1037 lines) Patch
D content/browser/quota/quota_database_unittest.cc View 1 chunk +0 lines, -698 lines 0 comments Download
D content/browser/quota/usage_tracker_unittest.cc View 1 chunk +0 lines, -339 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + storage/browser/quota/quota_database_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + storage/browser/quota/usage_tracker_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
pwnall
PTAL? This CL is only moves and BUILD.gn changes.
3 years, 8 months ago (2017-04-13 23:45:28 UTC) #4
kinuko
lgtm
3 years, 8 months ago (2017-04-14 05:39:03 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2813353003 Patch 1). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-14 05:39:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2817133002/1
3 years, 8 months ago (2017-04-14 06:15:49 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 06:22:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b0072b76bafcb7ef0db04a10f11...

Powered by Google App Engine
This is Rietveld 408576698