Remove caching of contents paint properties

Remove caching of contents paint properties

This patch stops caching contents paint properties which are rare
and take up a pointer on RarePaintData[1]. With this patch the
contents properties are recomputed from the local border box
properties as-needed.

[1] https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkDKQ822U/edit#gid=0

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2812593003
Cr-Commit-Position: refs/heads/master@{#463435}
Committed: https://chromium.googlesource.com/chromium/src/+/4389ecfd97b746892b3ec0d85137e9f62b69ba3a

[pdr., 2017-04-10 18:27:30]

Description was changed from

==========
Remove caching of contents paint properties



This patch stops caching contents paint properties which are rare

and take up a pointer on RarePaintData[1]. With this patch the

contents properties are recomputed from the local border box

properties as-needed.



[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...



BUG=700452
==========

to

==========
Remove caching of contents paint properties



This patch stops caching contents paint properties which are rare

and take up a pointer on RarePaintData[1]. With this patch the

contents properties are recomputed from the local border box

properties as-needed.



[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...



BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-04-10 18:27:50]

Description was changed from

==========
Remove caching of contents paint properties



This patch stops caching contents paint properties which are rare

and take up a pointer on RarePaintData[1]. With this patch the

contents properties are recomputed from the local border box

properties as-needed.



[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...



BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove caching of contents paint properties

This patch stops caching contents paint properties which are rare
and take up a pointer on RarePaintData[1]. With this patch the
contents properties are recomputed from the local border box
properties as-needed.

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
==========

[pdr., 2017-04-10 18:27:51]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, wangxianzhu@chromium.org

[pdr., 2017-04-10 18:28:17]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 18:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2017-04-10 19:44:50]

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3587: return
PropertyTreeState::Root();
Why would 3585 ever fail if the code is correct?

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (right):

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:47: auto
contents_properties = ancestor.ContentsProperties();
nit: Re-inline this?

[commit-bot: I haz the power, 2017-04-10 19:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:59:10]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-04-10 20:03:30]

Description was changed from

==========
Remove caching of contents paint properties

This patch stops caching contents paint properties which are rare
and take up a pointer on RarePaintData[1]. With this patch the
contents properties are recomputed from the local border box
properties as-needed.

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
==========

to

==========
Remove caching of contents paint properties

This patch stops caching contents paint properties which are rare
and take up a pointer on RarePaintData[1]. With this patch the
contents properties are recomputed from the local border box
properties as-needed.

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-04-10 20:05:34]

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3587: return
PropertyTreeState::Root();
On 2017/04/10 at 19:44:50, chrishtr wrote:
> Why would 3585 ever fail if the code is correct?

No. In the latest patch I refactored this to make it more clear.

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp (right):

https://codereview.chromium.org/2812593003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp:47: auto
contents_properties = ancestor.ContentsProperties();
On 2017/04/10 at 19:44:50, chrishtr wrote:
> nit: Re-inline this?

Done

[pdr., 2017-04-10 20:05:43]

PTAL

[chrishtr, 2017-04-10 20:50:30]

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3587: if
(!rare_paint_data_)
Remove this.

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/RarePaintData.cpp (right):

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/RarePaintData.cpp:34: if
(!local_border_box_properties_)
Get rid of this.

[pdr., 2017-04-10 20:56:34]

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutObject.cpp (right):

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutObject.cpp:3587: if
(!rare_paint_data_)
On 2017/04/10 at 20:50:30, chrishtr wrote:
> Remove this.

Done

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/RarePaintData.cpp (right):

https://codereview.chromium.org/2812593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/RarePaintData.cpp:34: if
(!local_border_box_properties_)
On 2017/04/10 at 20:50:30, chrishtr wrote:
> Get rid of this.

Done

[chrishtr, 2017-04-10 21:32:56]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-04-10 21:32:56]

lgtm

[commit-bot: I haz the power, 2017-04-10 21:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 23:07:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491859976114870,
"parent_rev": "7e5f99f2ae24ab7e04e9c944dc48cd2a7c46a0ad", "commit_rev":
"4389ecfd97b746892b3ec0d85137e9f62b69ba3a"}

[commit-bot: I haz the power, 2017-04-10 23:07:53]

Description was changed from

==========
Remove caching of contents paint properties

This patch stops caching contents paint properties which are rare
and take up a pointer on RarePaintData[1]. With this patch the
contents properties are recomputed from the local border box
properties as-needed.

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove caching of contents paint properties

This patch stops caching contents paint properties which are rare
and take up a pointer on RarePaintData[1]. With this patch the
contents properties are recomputed from the local border box
properties as-needed.

[1]
https://docs.google.com/spreadsheets/d/1IC1JI0sX7QsR9FmA4G1-F9E_c3xRKDNoV3SkD...

BUG=700452
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2812593003
Cr-Commit-Position: refs/heads/master@{#463435}
Committed:
https://chromium.googlesource.com/chromium/src/+/4389ecfd97b746892b3ec0d85137...
==========

[commit-bot: I haz the power, 2017-04-10 23:07:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4389ecfd97b746892b3ec0d85137...