Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2812593003: Remove caching of contents paint properties (Closed)
Patch Set: Address reviewer comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 // The complete set of property nodes that should be used as a starting point 406 // The complete set of property nodes that should be used as a starting point
407 // to paint this LayoutObject. See: m_localBorderBoxProperties comment. 407 // to paint this LayoutObject. See: m_localBorderBoxProperties comment.
408 const PropertyTreeState* LocalBorderBoxProperties() const { 408 const PropertyTreeState* LocalBorderBoxProperties() const {
409 DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()); 409 DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
410 if (rare_paint_data_) 410 if (rare_paint_data_)
411 return rare_paint_data_->LocalBorderBoxProperties(); 411 return rare_paint_data_->LocalBorderBoxProperties();
412 return nullptr; 412 return nullptr;
413 } 413 }
414 414
415 // The complete set of property nodes that should be used as a starting point 415 // The complete set of property nodes that should be used as a starting point
416 // to paint contents of this LayoutObject. See: m_contentsProperties comment. 416 // to paint contents of this LayoutObject.
417 const PropertyTreeState* ContentsProperties() const { 417 PropertyTreeState ContentsProperties() const;
418 DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
419 return rare_paint_data_ ? rare_paint_data_->ContentsProperties() : nullptr;
420 }
421 418
422 private: 419 private:
423 RarePaintData& EnsureRarePaintData(); 420 RarePaintData& EnsureRarePaintData();
424 RarePaintData* GetRarePaintData() { return rare_paint_data_.get(); } 421 RarePaintData* GetRarePaintData() { return rare_paint_data_.get(); }
425 422
426 ////////////////////////////////////////// 423 //////////////////////////////////////////
427 // Helper functions. Dangerous to use! 424 // Helper functions. Dangerous to use!
428 void SetPreviousSibling(LayoutObject* previous) { previous_ = previous; } 425 void SetPreviousSibling(LayoutObject* previous) { previous_ = previous; }
429 void SetNextSibling(LayoutObject* next) { next_ = next; } 426 void SetNextSibling(LayoutObject* next) { next_ = next; }
430 void SetParent(LayoutObject* parent) { 427 void SetParent(LayoutObject* parent) {
(...skipping 2395 matching lines...) Expand 10 before | Expand all | Expand 10 after
2826 CORE_EXPORT void showLineTree(const blink::LayoutObject*); 2823 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
2827 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1); 2824 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
2828 // We don't make object2 an optional parameter so that showLayoutTree 2825 // We don't make object2 an optional parameter so that showLayoutTree
2829 // can be called from gdb easily. 2826 // can be called from gdb easily.
2830 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1, 2827 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
2831 const blink::LayoutObject* object2); 2828 const blink::LayoutObject* object2);
2832 2829
2833 #endif 2830 #endif
2834 2831
2835 #endif // LayoutObject_h 2832 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698