third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2812593003: Remove caching of contents paint properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2812593003: Remove caching of contents paint properties (Closed)

Patch Set: Address reviewer comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 22a31999a0631cfd3d6b81222a611cbd7168140b..fa16b2787b844403abcfeff98d9553387bdb28a7 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -3580,6 +3580,11 @@ void LayoutObject::SetIsBackgroundAttachmentFixedObject(

GetFrameView()->RemoveBackgroundAttachmentFixedObject(this);

}

+PropertyTreeState LayoutObject::ContentsProperties() const {

+ DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());

+ return rare_paint_data_->ContentsProperties();

RarePaintData& LayoutObject::EnsureRarePaintData() {

if (!rare_paint_data_)

rare_paint_data_ = WTF::MakeUnique<RarePaintData>();