Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2812593003: Remove caching of contents paint properties (Closed)
Patch Set: Address reviewer comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 3562 matching lines...) Expand 10 before | Expand all | Expand 10 after
3573 is_background_attachment_fixed_object) 3573 is_background_attachment_fixed_object)
3574 return; 3574 return;
3575 bitfields_.SetIsBackgroundAttachmentFixedObject( 3575 bitfields_.SetIsBackgroundAttachmentFixedObject(
3576 is_background_attachment_fixed_object); 3576 is_background_attachment_fixed_object);
3577 if (is_background_attachment_fixed_object) 3577 if (is_background_attachment_fixed_object)
3578 GetFrameView()->AddBackgroundAttachmentFixedObject(this); 3578 GetFrameView()->AddBackgroundAttachmentFixedObject(this);
3579 else 3579 else
3580 GetFrameView()->RemoveBackgroundAttachmentFixedObject(this); 3580 GetFrameView()->RemoveBackgroundAttachmentFixedObject(this);
3581 } 3581 }
3582 3582
3583 PropertyTreeState LayoutObject::ContentsProperties() const {
3584 DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled());
3585 return rare_paint_data_->ContentsProperties();
3586 }
3587
3583 RarePaintData& LayoutObject::EnsureRarePaintData() { 3588 RarePaintData& LayoutObject::EnsureRarePaintData() {
3584 if (!rare_paint_data_) 3589 if (!rare_paint_data_)
3585 rare_paint_data_ = WTF::MakeUnique<RarePaintData>(); 3590 rare_paint_data_ = WTF::MakeUnique<RarePaintData>();
3586 return *rare_paint_data_.get(); 3591 return *rare_paint_data_.get();
3587 } 3592 }
3588 3593
3589 LayoutRect LayoutObject::DebugRect() const { 3594 LayoutRect LayoutObject::DebugRect() const {
3590 LayoutRect rect; 3595 LayoutRect rect;
3591 LayoutBlock* block = ContainingBlock(); 3596 LayoutBlock* block = ContainingBlock();
3592 if (block) 3597 if (block)
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
3648 const blink::LayoutObject* root = object1; 3653 const blink::LayoutObject* root = object1;
3649 while (root->Parent()) 3654 while (root->Parent())
3650 root = root->Parent(); 3655 root = root->Parent();
3651 root->ShowLayoutTreeAndMark(object1, "*", object2, "-", 0); 3656 root->ShowLayoutTreeAndMark(object1, "*", object2, "-", 0);
3652 } else { 3657 } else {
3653 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)"); 3658 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
3654 } 3659 }
3655 } 3660 }
3656 3661
3657 #endif 3662 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698