Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2810783002: Reland of move unreachable code in HttpStreamFactoryImpl::Job::Orphan (Closed)

Created:
3 years, 8 months ago by please use gerrit instead
Modified:
3 years, 8 months ago
Reviewers:
Bence, Mike West, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, Zhongyi Shi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move unreachable code in HttpStreamFactoryImpl::Job::Orphan (patchset #1 id:1 of https://codereview.chromium.org/2806383002/ ) Reason for revert: The build has stopped failing before this revert landed. Original issue's description: > Revert of Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan (patchset #1 id:1 of https://codereview.chromium.org/2801993006/ ) > > Reason for revert: > Compilation errors popped up in https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10288: > > ``` > [24309/50006] ACTION //net/http:transport_security_state_unittest_data(//build/toolchain/win:x64) > FAILED: gen/net/http/transport_security_state_static_unittest2.h > ``` > > This is the only patch in the range that touches //net, so even though it doesn't look related, let's revert it anyway. > > Original issue's description: > > Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan > > > > This CL removes unreachable code that handles WebSockets path in > > HttpStreamFactoryImpl::Job::Orphan(). > > > > WebSockets will not have two jobs, so the code is unreachable. > > > > This CL adds DCHECK(!for_websockets()) to make sure that the code > > is indeed not reachable. > > > > BUG=475060 > > > > Review-Url: https://codereview.chromium.org/2801993006 > > Cr-Commit-Position: refs/heads/master@{#463256} > > Committed: https://chromium.googlesource.com/chromium/src/+/1122620622afb5b96b2c7b3ea907e2a5fb633f27 > > TBR=bnc@chromium.org,xunjieli@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=475060 > > Review-Url: https://codereview.chromium.org/2806383002 > Cr-Commit-Position: refs/heads/master@{#463266} > Committed: https://chromium.googlesource.com/chromium/src/+/293aa6adadde2ee8e5266fb817582f7b7bc20b95 TBR=bnc@chromium.org,xunjieli@chromium.org,mkwst@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475060 Review-Url: https://codereview.chromium.org/2810783002 Cr-Commit-Position: refs/heads/master@{#463287} Committed: https://chromium.googlesource.com/chromium/src/+/d0c1239fccdfe80d9103a9eb45415b8664f5a736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -23 lines) Patch
M net/http/http_stream_factory_impl_job.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +1 line, -12 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
please use gerrit instead
Created Reland of move unreachable code in HttpStreamFactoryImpl::Job::Orphan
3 years, 8 months ago (2017-04-10 16:19:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810783002/1
3 years, 8 months ago (2017-04-10 16:19:27 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 16:21:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0c1239fccdfe80d9103a9eb4541...

Powered by Google App Engine
This is Rietveld 408576698