Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2806383002: Revert of Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan (Closed)

Created:
3 years, 8 months ago by Mike West
Modified:
3 years, 8 months ago
Reviewers:
Bence, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, Zhongyi Shi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan (patchset #1 id:1 of https://codereview.chromium.org/2801993006/ ) Reason for revert: Compilation errors popped up in https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10288: ``` [24309/50006] ACTION //net/http:transport_security_state_unittest_data(//build/toolchain/win:x64) FAILED: gen/net/http/transport_security_state_static_unittest2.h ``` This is the only patch in the range that touches //net, so even though it doesn't look related, let's revert it anyway. Original issue's description: > Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan > > This CL removes unreachable code that handles WebSockets path in > HttpStreamFactoryImpl::Job::Orphan(). > > WebSockets will not have two jobs, so the code is unreachable. > > This CL adds DCHECK(!for_websockets()) to make sure that the code > is indeed not reachable. > > BUG=475060 > > Review-Url: https://codereview.chromium.org/2801993006 > Cr-Commit-Position: refs/heads/master@{#463256} > Committed: https://chromium.googlesource.com/chromium/src/+/1122620622afb5b96b2c7b3ea907e2a5fb633f27 TBR=bnc@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=475060 Review-Url: https://codereview.chromium.org/2806383002 Cr-Commit-Position: refs/heads/master@{#463266} Committed: https://chromium.googlesource.com/chromium/src/+/293aa6adadde2ee8e5266fb817582f7b7bc20b95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M net/http/http_stream_factory_impl_job.h View 2 chunks +4 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +12 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
Created Revert of Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan
3 years, 8 months ago (2017-04-10 15:18:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806383002/1
3 years, 8 months ago (2017-04-10 15:18:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/293aa6adadde2ee8e5266fb817582f7b7bc20b95
3 years, 8 months ago (2017-04-10 15:20:33 UTC) #6
xunjieli
On 2017/04/10 15:20:33, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 8 months ago (2017-04-10 15:32:07 UTC) #7
please use gerrit instead
3 years, 8 months ago (2017-04-10 16:19:01 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2810783002/ by rouslan@chromium.org.

The reason for reverting is: The build has stopped failing before this revert
landed..

Powered by Google App Engine
This is Rietveld 408576698