DescriptionRevert of Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan (patchset #1 id:1 of https://codereview.chromium.org/2801993006/ )
Reason for revert:
Compilation errors popped up in https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10288:
```
[24309/50006] ACTION //net/http:transport_security_state_unittest_data(//build/toolchain/win:x64)
FAILED: gen/net/http/transport_security_state_static_unittest2.h
```
This is the only patch in the range that touches //net, so even though it doesn't look related, let's revert it anyway.
Original issue's description:
> Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan
>
> This CL removes unreachable code that handles WebSockets path in
> HttpStreamFactoryImpl::Job::Orphan().
>
> WebSockets will not have two jobs, so the code is unreachable.
>
> This CL adds DCHECK(!for_websockets()) to make sure that the code
> is indeed not reachable.
>
> BUG=475060
>
> Review-Url: https://codereview.chromium.org/2801993006
> Cr-Commit-Position: refs/heads/master@{#463256}
> Committed: https://chromium.googlesource.com/chromium/src/+/1122620622afb5b96b2c7b3ea907e2a5fb633f27
TBR=bnc@chromium.org,xunjieli@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475060
Review-Url: https://codereview.chromium.org/2806383002
Cr-Commit-Position: refs/heads/master@{#463266}
Committed: https://chromium.googlesource.com/chromium/src/+/293aa6adadde2ee8e5266fb817582f7b7bc20b95
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|