Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan

Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan

This CL removes unreachable code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

This CL adds DCHECK(!for_websockets()) to make sure that the code
is indeed not reachable.

BUG=475060
Review-Url: https://codereview.chromium.org/2801993006
Cr-Commit-Position: refs/heads/master@{#463256}
Committed: https://chromium.googlesource.com/chromium/src/+/1122620622afb5b96b2c7b3ea907e2a5fb633f27

[xunjieli, 2017-04-07 17:52:19]

Description was changed from

==========
Remove unnecessary code in HttpStreamFactoryImpl::Job

BUG=475060
==========

to

==========
Remove unnecessary code in HttpStreamFactoryImpl::Job

This CL removes unnecessary code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

BUG=475060
==========

[xunjieli, 2017-04-07 17:52:50]

xunjieli@chromium.org changed reviewers:
+ bnc@chromium.org

[xunjieli, 2017-04-07 17:52:51]

Bence, PTAL. Thank you.

[xunjieli, 2017-04-07 17:52:55]

The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:53:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-04-07 17:55:15]

Description was changed from

==========
Remove unnecessary code in HttpStreamFactoryImpl::Job

This CL removes unnecessary code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

BUG=475060
==========

to

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan

This CL removes unreachable code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

BUG=475060
==========

[xunjieli, 2017-04-07 17:55:54]

Description was changed from

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan

This CL removes unreachable code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

BUG=475060
==========

to

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan

This CL removes unreachable code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

This CL adds DCHECK(!for_websockets()) to make sure that the code
is indeed not reachable.

BUG=475060
==========

[commit-bot: I haz the power, 2017-04-07 18:55:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:55:46]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-04-09 19:09:12]

LGTM

[xunjieli, 2017-04-10 12:59:59]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:00:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:04:57]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[xunjieli, 2017-04-10 13:51:28]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:51:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:20:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491832288078630, "parent_rev":
"21c492878576af55fb89bf56efd9cbed20ef4eaa", "commit_rev":
"1122620622afb5b96b2c7b3ea907e2a5fb633f27"}

[commit-bot: I haz the power, 2017-04-10 14:20:59]

Description was changed from

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan

This CL removes unreachable code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

This CL adds DCHECK(!for_websockets()) to make sure that the code
is indeed not reachable.

BUG=475060
==========

to

==========
Remove unreachable code in HttpStreamFactoryImpl::Job::Orphan

This CL removes unreachable code that handles WebSockets path in
HttpStreamFactoryImpl::Job::Orphan().

WebSockets will not have two jobs, so the code is unreachable.

This CL adds DCHECK(!for_websockets()) to make sure that the code
is indeed not reachable.

BUG=475060

Review-Url: https://codereview.chromium.org/2801993006
Cr-Commit-Position: refs/heads/master@{#463256}
Committed:
https://chromium.googlesource.com/chromium/src/+/1122620622afb5b96b2c7b3ea907...
==========

[commit-bot: I haz the power, 2017-04-10 14:21:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1122620622afb5b96b2c7b3ea907...

[Mike West, 2017-04-10 15:18:39]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2806383002/ by mkwst@chromium.org.

The reason for reverting is: Compilation errors popped up in
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/10288:

```
[24309/50006] ACTION
//net/http:transport_security_state_unittest_data(//build/toolchain/win:x64)
FAILED: gen/net/http/transport_security_state_static_unittest2.h
```

This is the only patch in the range that touches //net, so even though it
doesn't look related, let's revert it anyway..