Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: net/http/http_stream_factory_impl_job_controller.h

Issue 2810783002: Reland of move unreachable code in HttpStreamFactoryImpl::Job::Orphan (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_job_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job_controller.h
diff --git a/net/http/http_stream_factory_impl_job_controller.h b/net/http/http_stream_factory_impl_job_controller.h
index 60e22e8d14416f03384392d8508c741c7e2e4fad..9a43bfb61499357648b6eadd32c3769cd66d5342 100644
--- a/net/http/http_stream_factory_impl_job_controller.h
+++ b/net/http/http_stream_factory_impl_job_controller.h
@@ -136,9 +136,6 @@
const base::WeakPtr<SpdySession>& spdy_session,
bool direct) override;
- // Invoked when the orphaned |job| finishes.
- void OnOrphanedJobComplete(const Job* job) override;
-
// Invoked when the |job| finishes pre-connecting sockets.
void OnPreconnectsComplete(Job* job) override;
@@ -166,7 +163,7 @@
// Remove session from the SpdySessionRequestMap.
void RemoveRequestFromSpdySessionRequestMapForJob(Job* job) override;
- const NetLogWithSource* GetNetLog(Job* job) const override;
+ const NetLogWithSource* GetNetLog() const override;
void MaybeSetWaitTimeForMainJob(const base::TimeDelta& delay) override;
@@ -208,6 +205,9 @@
// completion.
void OrphanUnboundJob();
+ // Invoked when the orphaned |job| finishes.
+ void OnOrphanedJobComplete(const Job* job);
+
// Called when a Job succeeds.
void OnJobSucceeded(Job* job);
« no previous file with comments | « net/http/http_stream_factory_impl_job.cc ('k') | net/http/http_stream_factory_impl_job_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698