Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2810743003: Move ScriptState::GetExecutionContext (Part 3) (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chasej+watch_chromium.org, chromium-reviews, iclelland+watch_chromuim.org, iclelland, jbroman+watch_chromium.org, lunalu1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptState::GetExecutionContext (Part 3) This CL replaces all uses of ScriptState::GetExecutionContext in Source/bindings with ExecutionContext::From. BUG=682322 Review-Url: https://codereview.chromium.org/2810743003 Cr-Commit-Position: refs/heads/master@{#463443} Committed: https://chromium.googlesource.com/chromium/src/+/0e704d39cb4a4f6382c87e7e22dbac4e85c57e7c

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -51 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Iterable.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 3 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 6 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueDeserializerForModules.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
adithyas
3 years, 8 months ago (2017-04-10 20:53:59 UTC) #2
jbroman
lgtm
3 years, 8 months ago (2017-04-10 21:04:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2810743003/20001
3 years, 8 months ago (2017-04-10 21:33:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0e704d39cb4a4f6382c87e7e22dbac4e85c57e7c
3 years, 8 months ago (2017-04-10 23:31:41 UTC) #10
haraken
3 years, 8 months ago (2017-04-11 00:00:21 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698