third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp - Issue 2810743003: Move ScriptState::GetExecutionContext (Part 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

Issue 2810743003: Move ScriptState::GetExecutionContext (Part 3) (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

index b12969e8869bc08bba9f70c7883c0113b7239e36..e10aca530dff88b30f66bd36cf0918c5ca16af1d 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

@@ -178,7 +178,8 @@ void V8V0CustomElementLifecycleCallbacks::Created(Element* element) {

v8::TryCatch exception_catcher(isolate);

exception_catcher.SetVerbose(true);

- V8ScriptRunner::CallFunction(callback, script_state_->GetExecutionContext(),

+ V8ScriptRunner::CallFunction(callback,

+ ExecutionContext::From(script_state_.Get()),

receiver, 0, 0, isolate);

}

@@ -220,7 +221,8 @@ void V8V0CustomElementLifecycleCallbacks::AttributeChanged(

v8::TryCatch exception_catcher(isolate);

exception_catcher.SetVerbose(true);

- V8ScriptRunner::CallFunction(callback, script_state_->GetExecutionContext(),

+ V8ScriptRunner::CallFunction(callback,

+ ExecutionContext::From(script_state_.Get()),

receiver, WTF_ARRAY_LENGTH(argv), argv, isolate);

}

@@ -245,7 +247,8 @@ void V8V0CustomElementLifecycleCallbacks::Call(

v8::TryCatch exception_catcher(isolate);

exception_catcher.SetVerbose(true);

- V8ScriptRunner::CallFunction(callback, script_state_->GetExecutionContext(),

+ V8ScriptRunner::CallFunction(callback,

+ ExecutionContext::From(script_state_.Get()),

receiver, 0, 0, isolate);

}