third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp - Issue 2810743003: Move ScriptState::GetExecutionContext (Part 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

Issue 2810743003: Move ScriptState::GetExecutionContext (Part 3) (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

index 80a7cf4d99653b478984faa590cacbc1be832080..aae32ef309930d80f9ab5455f6148ca0e2dbeb04 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp

@@ -16,7 +16,8 @@ void V8ResizeObserverCallback::handleEvent(

const HeapVector<Member<ResizeObserverEntry>>& entries,

ResizeObserver* observer) {

v8::Isolate* isolate = m_scriptState->GetIsolate();

- ExecutionContext* execution_context = m_scriptState->GetExecutionContext();

+ ExecutionContext* execution_context =

+ ExecutionContext::From(m_scriptState.Get());

if (!execution_context || execution_context->IsContextSuspended() ||

execution_context->IsContextDestroyed())

return;

@@ -45,7 +46,7 @@ void V8ResizeObserverCallback::handleEvent(

v8::TryCatch exception_catcher(m_scriptState->GetIsolate());

exception_catcher.SetVerbose(true);

V8ScriptRunner::CallFunction(

- m_callback.NewLocal(isolate), m_scriptState->GetExecutionContext(),

+ m_callback.NewLocal(isolate), ExecutionContext::From(m_scriptState.Get()),

this_object, WTF_ARRAY_LENGTH(argv), argv, isolate);

}